Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection

Yaniv Bronhaim has posted comments on this change.

Change subject: libvirtconnection: ping libvirt upon disconnection
......................................................................

Patch Set 12: -Code-Review

(1 comment)

Until you figure the testing issue, and you must (I felt that it can be risky), I added another minor comment to consider.

Anyhow, this change need to solve the vdsm restart occurrence. Now the migration to unknown network won't lead to reset of vdsm, but it still won't work until the required network will be configured properly, only appropriate log should be shown in the log (That's what I expected to see)

....................................................
File lib/vdsm/libvirtconnection.py
Line 131:             log.debug('trying to connect libvirt')
Line 132:             conn = utils.retry(libvirtOpenAuth, timeout=10, sleep=0.2)
Line 133:             __connections[id(target)] = conn
Line 134: 
Line 135:             setattr(conn, 'pingLibvirt', getattr(conn, 'getLibVersion'))
You need to catch here AttributeError. If the API is wrong and getLibVersion won't be there for any reason
Line 136:             for name in dir(libvirt.virConnect):
Line 137:                 method = getattr(conn, name)
Line 138:                 if callable(method) and name[0] != '_':
Line 139:                     setattr(conn, name, wrapMethod(method))