Daniel Erez has posted comments on this change.
Change subject: getDeviceList - passing includePartitioned to HSM
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 545: params = {'includePartitioned': includePartitioned}
* It would indeed be nicer - but it means that 'includePartitioned' is regarded as
a special option.
* Do we prefer 'includePartitioned' to be set to true by default?
* I've just followed the convention of using 'params' in vdsClient - I'l
change it to 'options'....
--
To view, visit
http://gerrit.ovirt.org/4828
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I388442f361ea4ae00e3d8878a2497c7819ab2214
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>