Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
......................................................................
Patch Set 11: Code-Review-1
(1 comment)
Maybe there's one more /32 address missing a slash.
https://gerrit.ovirt.org/#/c/33375/11/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 357: ipv4addr, prefix = ipv4addrs[0].split('/')
I cannot see prefix being used later and I fear that /32 address would bite here, so:
ipv4addr = ipv4addrs[0].split('/')[0]
--
To view, visit
https://gerrit.ovirt.org/33375
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni+ovirt(a)midokura.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt(a)midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes