Ido Barkan has posted comments on this change.
Change subject: relax the validation multiple networks on the same interface
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/34538/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 773: self.nics = _netinfo['nics']
Line 774: self.bondings = _netinfo['bondings']
Line 775: self.bridges = _netinfo['bridges']
Line 776:
Line 777: def getNetsByVlans(self, iface):
do this locally on client
Line 778: return dict((vlan, net)
Line 779: for (net, vlan)
Line 780: in self.getNetworksAndVlansForIface(iface))
Line 781:
http://gerrit.ovirt.org/#/c/34538/2/vdsm/network/api.py
File vdsm/network/api.py:
Line 179: else:
Line 180: raise ValueError('Invalid value for bridge stp')
Line 181:
Line 182:
Line 183: def _validateInterNetworkCompatibility(ni, vlan, iface):
call this in a for loop
Line 184: iface_nets_by_vlans = ni.getNetsByVlans(iface)
Line 185:
Line 186: if vlan in iface_nets_by_vlans:
Line 187: raise ConfigNetworkError(ne.ERR_BAD_PARAMS,
--
To view, visit
http://gerrit.ovirt.org/34538
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes