Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
......................................................................
Patch Set 4: Verified-1
(1 comment)
The basic command works as it should, but the error code is not propagated correctly.
Adding V-1 for now.
https://gerrit.ovirt.org/#/c/59834/4/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS4, Line 401: cmd = ['sh', '-c',
: 'exec 2>&1 "$@" | tee
"%s"' % logFile, # Command
: 'exec'] # Passed as
argv[0]
: cmd.extend(self._command())
I'm a bit confused, could you please show how the final command
line will l
The final command looks like:
'sh' '-c' 'exec 2>&1 "$@" | tee
"/var/log/vdsm/import/virt-v2v-<UUID>.log"' 'exec'
'/usr/bin/virt-v2v' '-v' '-x' '-ic'
'<libvirt_uri>' ... <other_v2v_options>
After execCmd kicks in and adds the wrappers, it will be:
'/usr/bin/taskset' '--cpu-list' '0-1' '/usr/bin/nice'
'-n' '19' '/usr/bin/ionice' '-c' '3' 'sh'
'-c' 'exec 2>&1 "$@" | tee
"/var/log/vdsm/import/virt-v2v-<UUID>.log"' 'exec'
'/usr/bin/virt-v2v' '-v' '-x' '-ic'
'<libvirt_uri>' ... <other_v2v_options>
--
To view, visit
https://gerrit.ovirt.org/59834
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes