Bala.FA has posted comments on this change.
Change subject: Provide device details using python-blivet module
......................................................................
Patch Set 3: Code-Review-1
(8 comments)
http://gerrit.ovirt.org/#/c/35028/3/vdsm/gluster/__init__.py
File vdsm/gluster/__init__.py:
Line 21: import os
Line 22: import tempfile
Line 23: from functools import wraps
Line 24:
Line 25: MODULE_LIST = ('cli', 'hooks', 'services',
'tasks', 'gfapi', 'storageconf')
change storageconf to storagedev?
Line 26:
Line 27:
Line 28: def makePublic(func):
Line 29: @wraps(func)
http://gerrit.ovirt.org/#/c/35028/3/vdsm/gluster/storageconf.py
File vdsm/gluster/storageconf.py:
Line 23:
Line 24: _bb = None
Line 25:
Line 26:
Line 27: def getBlivet():
Make it private function
Line 28: global _bb
Line 29: if _bb:
Line 30: return _bb
Line 31:
Line 52: if device.parents:
Line 53: info['container'] = device.parents[0].path
Line 54: info['parent'] = device.parents[0].name
Line 55: if hasattr(device.format, 'mountpoint'):
Line 56: info['contentType'] =
_getContentType(device.format.mountpoint)
remove contentType
Line 57: info['mount'] = device.format.mountpoint
Line 58: info['fileSystem'] = device.format.type
Line 59: info['model'] = device.model
Line 60: info['type'] = device.type
Line 53: info['container'] = device.parents[0].path
Line 54: info['parent'] = device.parents[0].name
Line 55: if hasattr(device.format, 'mountpoint'):
Line 56: info['contentType'] =
_getContentType(device.format.mountpoint)
Line 57: info['mount'] = device.format.mountpoint
do we need mount flags?
Line 58: info['fileSystem'] = device.format.type
Line 59: info['model'] = device.model
Line 60: info['type'] = device.type
Line 61: if device.uuid:
Line 54: info['parent'] = device.parents[0].name
Line 55: if hasattr(device.format, 'mountpoint'):
Line 56: info['contentType'] =
_getContentType(device.format.mountpoint)
Line 57: info['mount'] = device.format.mountpoint
Line 58: info['fileSystem'] = device.format.type
is it possible to get filesystem flags like inode size etc?
Line 59: info['model'] = device.model
Line 60: info['type'] = device.type
Line 61: if device.uuid:
Line 62: info['uuid'] = device.uuid
Line 58: info['fileSystem'] = device.format.type
Line 59: info['model'] = device.model
Line 60: info['type'] = device.type
Line 61: if device.uuid:
Line 62: info['uuid'] = device.uuid
1. Add device uuid as 'devuuid'
2. Add filesystem uuid as 'uuid'
Line 63: info['formattable'] = device.format.formattable
Line 64: info['resizable'] = device.format.resizable
Line 65: info['size'] = device.size
Line 66: deviceInfo.append(info)
Line 59: info['model'] = device.model
Line 60: info['type'] = device.type
Line 61: if device.uuid:
Line 62: info['uuid'] = device.uuid
Line 63: info['formattable'] = device.format.formattable
what is formattable?
Line 64: info['resizable'] = device.format.resizable
Line 65: info['size'] = device.size
Line 66: deviceInfo.append(info)
Line 60: info['type'] = device.type
Line 61: if device.uuid:
Line 62: info['uuid'] = device.uuid
Line 63: info['formattable'] = device.format.formattable
Line 64: info['resizable'] = device.format.resizable
what is resizable?
Line 65: info['size'] = device.size
Line 66: deviceInfo.append(info)
--
To view, visit
http://gerrit.ovirt.org/35028
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85f520c6f476731cb5982d8256cb701387be87cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nishanth Thomas <nishusemail(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes