Ido Barkan has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
......................................................................
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/33375/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 33: import struct
Line 34: import xml.etree.cElementTree as etree
Line 35:
Line 36: from . import constants
Line 37: from netaddr import IPNetwork
please place in former import block
Done
Line 38: from .ipwrapper import drv_name
Line 39: from .ipwrapper import DUMMY_BRIDGE
Line 40: from .ipwrapper import getLink, getLinks, Link
Line 41: from .ipwrapper import IPRoute2Error
https://gerrit.ovirt.org/#/c/33375/5/tests/netinfoTests.py
File tests/netinfoTests.py:
Line 353: 192.168.1.9
How about using the test range? I recall that there's another
patch brewing
Done
Line 375: 192.168.1.1
begs to be included as a named CONSTANT
Done
--
To view, visit
https://gerrit.ovirt.org/33375
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni+ovirt(a)midokura.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt(a)midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes