Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
......................................................................
Patch Set 19:
(1 comment)
http://gerrit.ovirt.org/#/c/26895/19/vdsm/API.py
File vdsm/API.py:
Line 206: return {'status': {'code':
errCode['MissParam']
Line 207:
['status']['code'],
Line 208: 'message': 'Missing required
'
Line 209: 'parameter %s' % (param)}}
Line 210: if 'display' not in vmParams and 'migrationDest' not
in vmParams:
would you remind me why this relaxation of requiredParams is needed,
and wh
I see the motivation for migrationDest to handle incoming "old"
configs, but what about an "old" engine running on "old" cluster level
using this new host/vdsm?
Line 211: return {'status': {'code':
errCode['MissParam']
Line 212:
['status']['code'],
Line 213: 'message': 'Missing required
'
Line 214: 'parameter display'}}
--
To view, visit
http://gerrit.ovirt.org/26895
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes