Change in vdsm[ovirt-3.5]: net: run dhclient in its own process group.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: net: run dhclient in its own process group.
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 791:     "Bring up an interface"
Line 792:     def _ifup(netIf):
Line 793:         cmd = [constants.EXT_IFUP, netIf]
Line 794: 
Line 795:         if not EL6 and cgroup is not None:
cgroup is a new argument, and I don't see code in this patch calling ifup with
cgroup=None, so this check seems unneeded. I guess this is the same on master?
Line 796:             cmd = cmdutils.systemd_run(cmd, scope=True, slice=cgroup)
Line 797: 
Line 798:         rc, out, err = utils.execCmd(cmd, raw=False)
Line 799: 


-- 
To view, visit https://gerrit.ovirt.org/43853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes