Change in vdsm[master]: tests: Add a live merge functional test

Yoav Kleinberger has posted comments on this change.

Change subject: tests: Add a live merge functional test
......................................................................

Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/29824/1/tests/functional/utils.py
File tests/functional/utils.py:

Line 238:         result = self.vdscli.getVolumeInfo(sdId, spId, imgId, volId)
Line 239:         return result['status']['code'], result['status']['message'],\
Line 240:             result['info']
Line 241: 
Line 242:     def createVolume(self, sdId, spId, imgId, size, volFormat, preallocate,
OK Nir, I agree.
Line 243:                      diskType, volId, desc, baseImgId, baseVolId):
Line 244:         result = self.vdscli.createVolume(sdId, spId, imgId, size, volFormat,
Line 245:                                           preallocate, diskType, volId, desc,
Line 246:                                           baseImgId, baseVolId)

http://gerrit.ovirt.org/#/c/29824/1/tests/functional/virtTests.py
File tests/functional/virtTests.py:

Line 552:                                                   jobId)
Line 553:                     jobIds.append(jobId)
Line 554:                 self._waitBlockJobs(vmId, jobIds)
Line 555:                 actual = self._getVolumeChains(vmId)
Line 556:                 self.assertEquals(chains, actual)
> The chance that you can sneak into the machines running this  test and inst

No one is going to mock VDSM. My point is that this doesn't really check what it should. On the other hand, all the other functional tests are the same. Waiting to hear what Adam has to say.