Adam Litke has posted comments on this change.
Change subject: Live Merge: Get volume chain for multiple drives
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31366/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 5509: ret = {}
Line 5510: domXML = self._getUnderlyingVmInfo()
Line 5511: for drive in drives:
Line 5512: alias = drive['alias']
Line 5513: diskXML = lookupDeviceXMLByAlias(domXML, alias)
Complexity is not a very big deal here, but n^2 iterations of drives
is not
Yes, I actually agree about the end target. Nice work has been done to move
xml parsing and generation to vmxml.py and I really like the idea of having a
domxml.getLiveVolumeChainInfo(). Francesco has some other refactoring ideas wrt
LiveMergeCleanupThread that I want to pursue as well.
That being said, we are looking for a working version in 3.5 and this does work. So
hopefully you can consent to a followup. I'll even open up a BZ to make sure it gets
tracked for 3.6 :)
Line 5514: if not diskXML:
Line 5515: continue
Line 5516: volChain = []
Line 5517: while True:
--
To view, visit
http://gerrit.ovirt.org/31366
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93d5a641b0814e3764c70bea8a6c1910a821adcc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes