Dan Kenigsberg has posted comments on this change.
Change subject: storage: Search only the current image for children
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/35096/2//COMMIT_MSG
Commit Message:
Line 12: problem is that deleteVolumes takes an exclusive lock on the image
Line 13: namespace only. If deletes are active on other images at the same time
Line 14: we'll get errors with missing files.
Line 15:
Line 16: The code mistakenly claims that children can be in any image on the
Would you agree to amend the commit message along the lines of:
"The code attempts to report children of a template's base volume. However, this
is not needed now and is not expected to be required in the future."
Line 17: storage domain. It appears that they are in fact limited to the same
Line 18: image. Therefore, the simplest resolution is to limit the search for
Line 19: children to the current image.
Line 20:
--
To view, visit
http://gerrit.ovirt.org/35096
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ef9012cee3a8cb891926510c10ecc47b7cddaa1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes