Francesco Romani has posted comments on this change.
Change subject: vm: log xml from/to libvirt at 'info' level
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/34358/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2843: # domDependentInit, after the migration is completed.
Line 2844:
Line 2845: if not self.recovering and initDomain:
Line 2846: domxml = hooks.before_vm_start(self._buildDomainXML(), self.conf)
Line 2847: self.log.info(domxml)
This is not info level message - this is debug message.
Yes, I
see your point.
The thing is: we (or at very least I) like to see the XML traffic between VDSM and libvirt
even if we make both silent.
This is because the XML is probably the single most important information we pass around,
and I'd like to keep it for the time being as a cautionary move.
But I fully concur that this is really debug() and not info().
What do you suggest? Maybe separate log file?
Line 2848:
Line 2849: if self.recovering:
Line 2850: self._dom = NotifyingVirDomain(
Line 2851: self._connection.lookupByUUIDString(self.id),
Line 2959: nicXml = nic.getXML().toprettyxml(encoding='utf-8')
Line 2960: nicXml = hooks.before_nic_hotplug(nicXml, self.conf,
Line 2961: params=nic.custom)
Line 2962: nic._deviceXML = nicXml
Line 2963: self.log.info("Hotplug NIC xml: %s", nicXml)
Do we need the whole xml or only few values from it?
Most
likely yes, this is was just the easy route :)
Let me try to come with a better solution.
(here and all the other chunks).
Line 2964:
Line 2965: try:
Line 2966: self._dom.attachDevice(nicXml)
Line 2967: except libvirt.libvirtError as e:
--
To view, visit
http://gerrit.ovirt.org/34358
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07823512a8cdf5f05789b29bf3d4daa1a8ccb07
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes