Ayal Baron has posted comments on this change.
Change subject: BZ#788640 - Refactor Pool.deleteImage()
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(2 inline comments)
Minor comments, please fix either in this or subsequent patch.
....................................................
File vdsm/storage/sp.py
Line 1717: # Threfore move this to .*SD class
s/Thre/There/
s/.*SD/relevant *sd module/
Line 1727: # derived images, e.g. no template based
s/no template based/not derived from a template/
--
To view, visit
http://gerrit.ovirt.org/3464
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc1397c69c7ffa835abe0747b6573d56bb9d74e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>