Nir Soffer has posted comments on this change.
Change subject: getFileList() filters files in case incensitive manner
......................................................................
Patch Set 1:
(2 comments)
Hopefully it will be easy to get this minimal change merged, but in this case we should
consider a bigger change.
getFileList() was never used; this is our only chance to fix it:
- Fix the name; it should be getFileStats. Using List in an API is a poor choice.
- Add a caseSensitive flag
- Remove the unused options parameter
So a better change would be to depreciate getFileList and add a proper one instead.
....................................................
Commit Message
Line 3: AuthorDate: 2013-10-23 23:36:03 +0300
Line 4: Commit: Sergey Gotliv <sgotliv(a)redhat.com>
Line 5: CommitDate: 2013-10-23 23:57:55 +0300
Line 6:
Line 7: getFileList() filters files in case incensitive manner
Not clear if this is a description of the previous state or the new one. How about:
Use case insensitive search in getFileList()
Line 8:
Line 9: Currently Engine is using getIsoList() and getFloppyList() APIs to
Line 10: retrieve the list of iso and floppy files respectively. Both these APIs
Line 11: are working in case incensitive manner but don't provide file
Line 10: retrieve the list of iso and floppy files respectively. Both these APIs
Line 11: are working in case incensitive manner but don't provide file
Line 12: statistics. Changing getFileList(), which is already providing full
Line 13: information about files, to be case incensitive will make it adoption
Line 14: easier.
The last sentence could be more clear as:
getFileList() returns file statistics but use case sensitive search. Using case
insensitive search allow using getFileList() instead of getIsoList() and getFloppyList().
And dont forget to mention that:
getFileList() was never used in the engine, so this change should be safe.
Line 15:
Line 16: Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23
--
To view, visit
http://gerrit.ovirt.org/20476
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes