Dan Kenigsberg has posted comments on this change.
Change subject: nfs-check improvements
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
and please add yourself as an AUTHOR.
....................................................
File contrib/nfs-check.py
Line 181: process = cmdRet[0]
I know it is "only" a contrib script, and that it does command-line building
(arghh), but still:
process, errorMsg, ret = self.runCommand(cmdTouch)
would be so much cleaner!
Line 238: errorMsg = process.communicate()[1].strip()
it is a bad practice for a function to assume that trailing whitespace of all cmd is
meaningless. I'd suggest to strip the error outside (if needed).
Line 247: return cmdRet
simpler and nicer:
return process, errorMsg, ret
and loos cmdRet.
--
To view, visit
http://gerrit.ovirt.org/3081
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I939476dbbad0f97b43b8dff4dc2c5913cb3d1a1e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>