Francesco Romani has posted comments on this change.
Change subject: ppc64le: vm.py support for running ppc64le systems
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/39216/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-03-23 17:36:12 +0100
Line 4: Commit: Martin Polednik <mpolednik(a)redhat.com>
Line 5: CommitDate: 2015-03-26 11:10:32 +0100
Line 6:
Line 7: ppc64le: vm.py support for running ppc64le systems
s/vm.py/virt/
my rule is:
vm: if the patch affects vm only (and it is quite often the case, e.g. the Vm class)
virt: if the patch affects more than a module of the virt package, or something in the
'virt' vertical
Line 8:
Line 9: Our architecture check lacked ppc64le. This patch fixes it by adding it
Line 10: as a supported architecture and adding default machine type for it.
Line 11:
https://gerrit.ovirt.org/#/c/39216/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 804: self._watchdogEvent = {}
Line 805: self.arch = caps.getTargetArch()
Line 806:
Line 807: if self.arch not in caps.Architecture.POWER and \
Line 808: self.arch != caps.Architecture.X86_64:
thanks :)
Line 809: raise RuntimeError('Unsupported architecture: %s' %
self.arch)
Line 810:
Line 811: self._powerDownEvent = threading.Event()
Line 812: self._liveMergeCleanupThreads = {}
--
To view, visit
https://gerrit.ovirt.org/39216
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad44c79bfee11745cce530312f283c8d0b5ce9a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes