Change in vdsm[master]: ppc64le: vm.py support for running ppc64le systems

Francesco Romani has posted comments on this change.

Change subject: ppc64le: vm.py support for running ppc64le systems
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/39216/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 803:         self.saveState()
Line 804:         self._watchdogEvent = {}
Line 805:         self.arch = caps.getTargetArch()
Line 806: 
Line 807:         if self.arch not in caps.Architecture.POWER or self.arch !=
'x86_64':
In a future patch: can we use nicer caps.Architecutre.SOMETHING also for x86_64 here?

Could it be nicer if we add a classmethod like supported() to caps.Architecture so
we'll be able to write

  if not caps.Architecture.supported(self.arch):
    ...
Line 808:             raise RuntimeError('Unsupported architecture: %s' %
self.arch)
Line 809: 
Line 810:         self._powerDownEvent = threading.Event()
Line 811:         self._liveMergeCleanupThreads = {}


-- 
To view, visit https://gerrit.ovirt.org/39216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad44c79bfee11745cce530312f283c8d0b5ce9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes