3:44 a.m.
Allon Mureinik has uploaded a new change for review.
Change subject: sdc.py: Remove domain before activating
......................................................................
sdc.py: Remove domain before activating
When a domain is activated, we should not rely on the cache as the
domain's connection data may have been edited while it was deactivated.
Change-Id: I458132878f2ae39f9efec6420dd582bfc2f888fc
Bug-Url: https://bugzilla.redhat.com/950055
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/18458/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 3f3c1bf..5aafd9c 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1102,6 +1102,7 @@
"""
self.log.info("sdUUID=%s spUUID=%s", sdUUID, self.spUUID)
+ sdCache.manuallyRemoveDomain(sdUUID)
dom = sdCache.produce(sdUUID)
# Avoid domain activation if not owned by pool
self.validateAttachedDomain(dom)
--
To view, visit http://gerrit.ovirt.org/18458
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I458132878f2ae39f9efec6420dd582bfc2f888fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
3:29 a.m.
Allon Mureinik has abandoned this change.
Change subject: sdc.py: Remove domain before activating
......................................................................
Abandoned
Patch was tested on a single-host deployment, which is obviously wrong.
The problem should probably be addressed in sdc.py, where we return the domain object
despite the self.STORAGE_STALE, as Eduardo rightfully pointed out in the BZ.
Abandoning.
--
To view, visit http://gerrit.ovirt.org/18458
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I458132878f2ae39f9efec6420dd582bfc2f888fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:22 p.m.
Eduardo has posted comments on this change.
Change subject: sdc.py: Remove domain before activating
......................................................................
Patch Set 1: Code-Review-2
This patch it is not related at all with the BZ and only will slow significatively the
storage operations.
--
To view, visit http://gerrit.ovirt.org/18458
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I458132878f2ae39f9efec6420dd582bfc2f888fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:13 a.m.
Ayal Baron has posted comments on this change.
Change subject: sdc.py: Remove domain before activating
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18458
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I458132878f2ae39f9efec6420dd582bfc2f888fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:48 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sdc.py: Remove domain before activating
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4122/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3227/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4043/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/18458
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I458132878f2ae39f9efec6420dd582bfc2f888fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:45 a.m.
Allon Mureinik has posted comments on this change.
Change subject: sdc.py: Remove domain before activating
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18458
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I458132878f2ae39f9efec6420dd582bfc2f888fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-HasComments: No
3912
days inactive
3922
days old
vdsm-patches@lists.fedorahosted.org
5 comments
4 participants
participants (4)
-
abaron＠redhat.com -
Allon Mureinik -
ewarszaw＠redhat.com -
Jenkins CI RO