4:24 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: spec: remove shared glusterfs requirements
......................................................................
spec: remove shared glusterfs requirements
Since we now require glusterfs in the main package we can now remove the
same dependencies from the gluster rpm.
Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/18408/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 74ad331..9666cc6 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -525,10 +525,7 @@
BuildArch: noarch
Requires: %{name} = %{version}-%{release}
-Requires: glusterfs >= 3.4.0
Requires: glusterfs-server
-Requires: glusterfs-fuse
-Requires: glusterfs-rdma
Requires: python-magic
%description gluster
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
10:12 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: remove shared glusterfs requirements
......................................................................
spec: remove shared glusterfs requirements
Since we now require glusterfs in the main package we can now remove the
same dependencies from the gluster rpm.
Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/18408
Reviewed-by: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-by: Allon Mureinik <amureini(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Federico Simoncelli: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Deepak C Shetty: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:12 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:49 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
......................................................................
Patch Set 1: Verified+1
verified with:
$ rpm -qRp vdsm-gluster-4.12.0-102.gitde6f9a2.el6_4.noarch.rpm
vdsm = 4.12.0-102.gitde6f9a2.el6_4
glusterfs-server
python-magic
...
$ rpm -qRp vdsm-4.12.0-102.gitde6f9a2.el6_4.x86_64.rpm
...
glusterfs >= 3.4.0
glusterfs-api
glusterfs-cli
glusterfs-fuse
glusterfs-rdma
...
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:21 a.m.
Allon Mureinik has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:24 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:44 a.m.
Deepak C Shetty has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
......................................................................
Patch Set 1:
When we use a node as a gluster node (not as hypervisor/vdsm) i think it will only install
vdsm-gluster, in which case we still would need the deps to be part of the vdsm-gluster
pkg, no ?
I never tested on gluster only node.. Bala might be the right person to comment.
thanx,
deepak
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:30 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4081/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3186/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4002/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:12 a.m.
Deepak C Shetty has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
......................................................................
Patch Set 1: Code-Review+1
vdsm-gluster indeed requires 'vdsm' main pkg.. so I am fine with this.
--
To view, visit http://gerrit.ovirt.org/18408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cdbf9a0bc97ce0bf42b0b7647a2641717442d58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3894
days inactive
3907
days old
vdsm-patches@lists.fedorahosted.org
8 comments
6 participants
participants (6)
-
Allon Mureinik -
Dan Kenigsberg -
deepakcs＠linux.vnet.ibm.com -
Douglas Schilling Landgraf -
Federico Simoncelli -
Jenkins CI RO