Dan Kenigsberg has uploaded a new change for review.
Change subject: tcTests: make non-local tests run ......................................................................
tcTests: make non-local tests run
Change-Id: I68e4b42c12a6494cbfd73245e3427bab2943c499 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/tcTests.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/7570/1
diff --git a/tests/tcTests.py b/tests/tcTests.py index db6304f..dee8c5b 100644 --- a/tests/tcTests.py +++ b/tests/tcTests.py @@ -34,7 +34,7 @@
from testrunner import VdsmTestCase as TestCaseBase from testValidation import ValidateRunningAsRoot -from constants import EXT_BRCTL, EXT_TC +from vdsm.constants import EXT_BRCTL, EXT_TC from nose.plugins.skip import SkipTest
import tc
-- To view, visit http://gerrit.ovirt.org/7570 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I68e4b42c12a6494cbfd73245e3427bab2943c499 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests rpm: make non-local tests run ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/748/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7570 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68e4b42c12a6494cbfd73245e3427bab2943c499 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has posted comments on this change.
Change subject: tests rpm: make non-local tests run ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/7570 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68e4b42c12a6494cbfd73245e3427bab2943c499 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has posted comments on this change.
Change subject: tests rpm: make non-local tests run ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
we need to write wiki page about how to add ut and its temp files so everything will be in the right location after installation: 1. add to makefile.am under section dist_vdsmtests_DATA\SCRIPTS your temp files. 2. add to spec the desire destination for those files.
-- To view, visit http://gerrit.ovirt.org/7570 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68e4b42c12a6494cbfd73245e3427bab2943c499 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: tests rpm: make non-local tests run ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7570 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68e4b42c12a6494cbfd73245e3427bab2943c499 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests rpm: make non-local tests run ......................................................................
tests rpm: make non-local tests run
We should ship vdsm-tests.rpm with all its required files.
Change-Id: I68e4b42c12a6494cbfd73245e3427bab2943c499 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/Makefile.am M tests/tcTests.py M vdsm.spec.in 3 files changed, 15 insertions(+), 11 deletions(-)
Approvals: Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7570 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I68e4b42c12a6494cbfd73245e3427bab2943c499 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org