Change in vdsm[master]: BZ#785557 bootstrap: do not mark mgmt bridge as NM_CONTROLLE...

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: BZ#785557 bootstrap: do not mark mgmt bridge as NM_CONTROLLED
......................................................................

BZ#785557 bootstrap: do not mark mgmt bridge as NM_CONTROLLED

Network devices created by Vdsm should ask to be controlled by
NetworkManager. Particularly when NM does not support controlling them
(bridge device).

Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
---
M vdsm_reg/deployUtil.py.in
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/1370/1
--
To view, visit http://gerrit.ovirt.org/1370
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

Change in vdsm[master]: BZ#785557 bootstrap: do not mark ifcfg as NM_CONTROLLED

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#785557 bootstrap: do not mark ifcfg as NM_CONTROLLED
......................................................................


BZ#785557 bootstrap: do not mark ifcfg as NM_CONTROLLED

Network devices created by Vdsm should not ask to be controlled by
NetworkManager. Particularly when NM does not support controlling them
(bridge device).

However, we require that the non-default network.service is started in
order to control them.

Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
---
M vdsm/configNetwork.py
M vdsm/vdsmd.service
M vdsm_reg/deployUtil.py.in
3 files changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Rami Vaknin: Verified


--
To view, visit http://gerrit.ovirt.org/1370
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#785557 bootstrap: do not mark ifcfg as NM_CONTROLLED

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#785557 bootstrap: do not mark ifcfg as NM_CONTROLLED
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1370
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: BZ#785557 bootstrap: do not mark mgmt bridge as NM_CONTROLLED
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1370
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#785557 bootstrap: do not mark ifcfg as NM_CONTROLLED

Rami Vaknin has posted comments on this change.

Change subject: BZ#785557 bootstrap: do not mark ifcfg as NM_CONTROLLED
......................................................................


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/1370
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;