Shahar Havivi has uploaded a new change for review.
Change subject: promisc hook: release monitor traffic on before_vm_destory ......................................................................
promisc hook: release monitor traffic on before_vm_destory
after_vm_destroy is too late to release tc monitor traffic, moving the event to before_vm_destroy event.
Change-Id: I80c4d688668e299c1eee4a4a9fbfb00ced9ccbd7 --- M vdsm.spec.in M vdsm_hooks/promisc/Makefile.am R vdsm_hooks/promisc/before_vm_destroy.py 3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/1581/1 -- To view, visit http://gerrit.ovirt.org/1581 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I80c4d688668e299c1eee4a4a9fbfb00ced9ccbd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: promisc hook: release monitor traffic on before_vm_destory ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/1581 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I80c4d688668e299c1eee4a4a9fbfb00ced9ccbd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: promisc hook: release monitor traffic on before_vm_destory ......................................................................
Patch Set 1: Looks good to me, approved
you want it - you've got it.
-- To view, visit http://gerrit.ovirt.org/1581 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I80c4d688668e299c1eee4a4a9fbfb00ced9ccbd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: promisc hook: release monitor traffic on before_vm_destory ......................................................................
promisc hook: release monitor traffic on before_vm_destory
after_vm_destroy is too late to release tc monitor traffic, moving the event to before_vm_destroy event.
Change-Id: I80c4d688668e299c1eee4a4a9fbfb00ced9ccbd7 --- M vdsm.spec.in M vdsm_hooks/promisc/Makefile.am R vdsm_hooks/promisc/before_vm_destroy.py 3 files changed, 6 insertions(+), 6 deletions(-)
Approvals: Shahar Havivi: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1581 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I80c4d688668e299c1eee4a4a9fbfb00ced9ccbd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
vdsm-patches@lists.fedorahosted.org