Change in vdsm[master]: Add an initial systemd service file for vdsm-reg

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Add an initial systemd service file for vdsm-reg
......................................................................

Add an initial systemd service file for vdsm-reg

Change-Id: I7b93375bc780ad9304ef5184746a568b066a564c
---
M vdsm.spec.in
M vdsm_reg/Makefile.am
A vdsm_reg/vdsm-reg.service
3 files changed, 45 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/321/1
--
To view, visit http://gerrit.ovirt.org/321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b93375bc780ad9304ef5184746a568b066a564c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add an initial systemd service file for vdsm-reg
......................................................................


Patch Set 5: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b93375bc780ad9304ef5184746a568b066a564c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add an initial systemd service file for vdsm-reg
......................................................................


Add an initial systemd service file for vdsm-reg

Change-Id: I7b93375bc780ad9304ef5184746a568b066a564c
---
M vdsm.spec.in
M vdsm_reg/Makefile.am
R vdsm_reg/vdsm-reg.init
A vdsm_reg/vdsm-reg.service
4 files changed, 46 insertions(+), 16 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b93375bc780ad9304ef5184746a568b066a564c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Add an initial systemd service file for vdsm-reg
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm_reg/Makefile.am
Line 67
Fixed, thanks. The old spec file was looking in the wrong place (/etc/init.d/vdsm-reg
instead of /etc/rc.d/init.d/vdsm-reg).

--
To view, visit http://gerrit.ovirt.org/321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b93375bc780ad9304ef5184746a568b066a564c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add an initial systemd service file for vdsm-reg
......................................................................


Patch Set 4: Fails

(1 inline comment)

....................................................
File vdsm_reg/Makefile.am
Line 67
RPM build errors:
    File not found: .../BUILDROOT/vdsm-4.9.1-0.55.g87a2f5b.el6.x86_64/etc/init.d/vdsm-reg
(rhel host)

--
To view, visit http://gerrit.ovirt.org/321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b93375bc780ad9304ef5184746a568b066a564c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;