Change in vdsm[master]: [WIP] Install the SysV init file only when needed

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: [WIP] Install the SysV init file only when needed
......................................................................

[WIP] Install the SysV init file only when needed

Change-Id: I839e23126c7cd9814fd8ebdd18aa9067649915d4
---
M vdsm.spec.in
M vdsm/Makefile.am
R vdsm/vdsmd.init.in
3 files changed, 38 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/262/1
--
To view, visit http://gerrit.ovirt.org/262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I839e23126c7cd9814fd8ebdd18aa9067649915d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: Add an initial systemd service file for vdsmd

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add an initial systemd service file for vdsmd
......................................................................


Patch Set 9: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I839e23126c7cd9814fd8ebdd18aa9067649915d4
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: Add an initial systemd service file for vdsmd

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add an initial systemd service file for vdsmd
......................................................................


Add an initial systemd service file for vdsmd

Change-Id: I839e23126c7cd9814fd8ebdd18aa9067649915d4
---
M .gitignore
M vdsm.spec.in
M vdsm/Makefile.am
R vdsm/vdsmd.init.in
A vdsm/vdsmd.service
5 files changed, 79 insertions(+), 23 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I839e23126c7cd9814fd8ebdd18aa9067649915d4
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: Install the SysV init file only when needed

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Install the SysV init file only when needed
......................................................................


Patch Set 3:

note to self - on its own, this patch breaks Fedora build. It must be accompanied by the
following patch that introduces systemd init.

--
To view, visit http://gerrit.ovirt.org/262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I839e23126c7cd9814fd8ebdd18aa9067649915d4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: Install the SysV init file only when needed

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Install the SysV init file only when needed
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm.spec.in
Line 125: # Install the init script
I'd say explicitly that it's the SysV init script

--
To view, visit http://gerrit.ovirt.org/262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I839e23126c7cd9814fd8ebdd18aa9067649915d4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;