12:08 p.m.
Wenchao Xia has uploaded a new change for review.
Change subject: reorganize tests directory This patch does two things: Put all test
cases into subdir UT, make testrunner automatically searching for cases instead of hard
coding. The purpose is to easy adding more UT cases and adding another type of test sets
as VT in
......................................................................
reorganize tests directory
This patch does two things: Put all test cases into subdir
UT, make testrunner automatically searching for cases instead of
hard coding. The purpose is to easy adding more UT cases and adding
another type of test sets as VT in the future.
Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Signed-off-by: wenchao xia <xiawenc(a)linux.vnet.ibm.com>
---
M tests/Makefile.am
R tests/UT/alignmentScanTests.py
R tests/UT/betterThreadingTests.py
R tests/UT/fileUtilTests.py
R tests/UT/guestIFTests.py
R tests/UT/hooksTests.py
R tests/UT/main.py
R tests/UT/md_utils_tests.py
R tests/UT/miscTests.py
R tests/UT/parted_utils_tests.py
R tests/UT/persistentDictTests.py
R tests/UT/processPoolTests.py
R tests/UT/resourceManagerTests.py
M tests/testrunner.py
14 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/3923/1
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
7:26 p.m.
New subject: Change in vdsm[master]: reorganize tests directory
Saggi Mizrahi has posted comments on this change.
Change subject: reorganize tests directory
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
Commit Message
Line 11: hard coding. The purpose is to easy adding more UT cases and adding
+1
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
11:19 a.m.
New subject: Change in vdsm[master]: introducing test package to vdsm
Wenchao Xia has posted comments on this change.
Change subject: introducing test package to vdsm
......................................................................
Patch Set 4: (7 inline comments)
I am trying to adjust the test package as following:
tests
|testrrunner.py
|run_test.sh
|validate.py
--ut
| |-*.py
|
--vt
|--rest
|--*.py
|--xmlrpc
|--*.py
Because vt case should be run after installation at target machine, so I want to class
the test cases into different directories, and user can choose cases to run.
....................................................
File tests/testrunner.py
Line 156: def search_files(path, suffix):
function removed
Line 186: print "running test suits %s..." %
case_unit["name"]
Done
Line 220: parser.add_argument('--case', help='''specify a case or
a directory
using nose searching capability now, but still keeps case option for easying the coding.
Line 225: inputArgs = sys.argv[1:]
argparser got error if arg[0]is given
Line 226: args = parser.parse_args(inputArgs)
I did not find a good way to pop the args that have been parsed, so I am still combining
args nose got from the argparser result.
Line 240: print "hacking vdsm modles..."
Done
Line 244: def genCaseList(testConfig):
Done
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
4:19 p.m.
New subject: Change in vdsm[master]: introducing test package to vdsm
Saggi Mizrahi has posted comments on this change.
Change subject: introducing test package to vdsm
......................................................................
Patch Set 4: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
4:19 p.m.
New subject: Change in vdsm[master]: introducing test package to vdsm
Saggi Mizrahi has posted comments on this change.
Change subject: introducing test package to vdsm
......................................................................
Patch Set 4: (7 inline comments)
This patch does too many things and is a bit confusing, please have every change in
it's own patch.
I still don't understand why you want to move the files around.
....................................................
File tests/testrunner.py
Line 156: def search_files(path, suffix):
Remove this function, use glob
Line 186: print "running test suits %s..." %
case_unit["name"]
stream.write
Line 220: parser.add_argument('--case', help='''specify a case or
a directory
This entire option is redundant, it's already built in, just add the ut folder to
nose's search path.
This will not solve the issue of being able to tab to autocomplete module names
Line 225: inputArgs = sys.argv[1:]
There is no need to eliminate the first arg
Line 226: args = parser.parse_args(inputArgs)
Pop your args from the agrv list so they don't confuse nose.
Line 240: print "hacking vdsm modles..."
stream.write
Line 244: def genCaseList(testConfig):
Again, this entire function is redundant, just add ./ut to nose's search path.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
5:12 a.m.
New subject: Change in vdsm[master]: reorganize the test diretory
Wenchao Xia has abandoned this change.
Change subject: reorganize the test diretory
......................................................................
Patch Set 7: Abandoned
conflict with Adam's patch
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
5:01 a.m.
New subject: Change in vdsm[master]: reorganize the test diretory
Wenchao Xia has posted comments on this change.
Change subject: reorganize the test diretory
......................................................................
Patch Set 7:
I don't know how to let nose search for the cases that as named as original mixed
style, except "*.py". My purpose is to let nose search the case when user
specify a diretory such as "./ut".
Patch was modified according to previous comments, sorry if I missed something.
Abandon this changed due to conflict with Adam's test package patch.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
11:23 p.m.
New subject: Change in vdsm[master]: reorganize the test diretory
Saggi Mizrahi has posted comments on this change.
Change subject: reorganize the test diretory
......................................................................
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
11:21 p.m.
New subject: Change in vdsm[master]: reorganize the test diretory
Saggi Mizrahi has posted comments on this change.
Change subject: reorganize the test diretory
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
Why change all the file to not conform to the mixedCase style we use everywhere else.
Also non of my previous comments have been addressed
....................................................
File tests/testrunner.py
Line 212: parser.add_argument('--vdsm_replace',
convention is to use a dash not an underscore
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
7:29 a.m.
New subject: Change in vdsm[master]: reorganize the test diretory
Wenchao Xia has posted comments on this change.
Change subject: reorganize the test diretory
......................................................................
Patch Set 7: (1 inline comment)
....................................................
Commit Message
Line 19: betterPopenTests.py was changed a bit to avoid fail in importing after
when the case parameter is "./ut", the nose will search the case with name
"*._tests.py" by default, so I changed the case names to let nose's
searching works. "./ut/*.py" seems not the same as "/ut" if
"ut/case_set1" exist.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
9:11 p.m.
New subject: Change in vdsm[master]: reorganize the test diretory
Dan Kenigsberg has posted comments on this change.
Change subject: reorganize the test diretory
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
off-centric comment
....................................................
Commit Message
Line 19: betterPopenTests.py was changed a bit to avoid fail in importing after
this is better done in a separate patch. I certainly do not understand why you've
renamed the file.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
11:26 a.m.
New subject: Change in vdsm[master]: introducing test package to vdsm
Wenchao Xia has posted comments on this change.
Change subject: introducing test package to vdsm
......................................................................
Patch Set 2: (1 inline comment)
....................................................
Commit Message
Line 11: hard coding. The purpose is to easy adding more UT cases and adding
done, now testrunner.py accpet parameter to run only one case.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
7:28 p.m.
New subject: Change in vdsm[master]: reorganize tests directory
Saggi Mizrahi has posted comments on this change.
Change subject: reorganize tests directory
......................................................................
Patch Set 2: (1 inline comment)
....................................................
Commit Message
Line 11: hard coding. The purpose is to easy adding more UT cases and adding
You could solve this by having run_tests.sh run the entire suite and have the first arg be
the filter.
It will just be annoying trying to run new tests modules.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
9:03 a.m.
New subject: Change in vdsm[master]: reorganize tests directory
Dan Kenigsberg has posted comments on this change.
Change subject: reorganize tests directory
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
I understand this is a part of some grand plan; please augment with a subsequent patch,
since as it is, I do not understand where this patch is going.
....................................................
Commit Message
Line 11: hard coding. The purpose is to easy adding more UT cases and adding
but I like and enjoy
./testrunner.py <specific-test-module>
Please keep this possibility.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
8:35 a.m.
New subject: Change in vdsm[master]: reorganize tests directory
Wenchao Xia has posted comments on this change.
Change subject: reorganize tests directory
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <sming56(a)gmail.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>
4377
days inactive
4403
days old
vdsm-patches@lists.fedorahosted.org
14 comments
3 participants
participants (3)
-
Dan Kenigsberg -
smizrahi＠redhat.com -
xiawenc＠linux.vnet.ibm.com