Change in vdsm[master]: Adding KSM pages_shared and pages_sharing stats (in MBytes).

Amador Pahim has uploaded a new change for review.

Change subject: Adding KSM pages_shared and pages_sharing stats (in MBytes).
......................................................................

Adding KSM pages_shared and pages_sharing stats (in MBytes).

Change-Id: Id5948b4eb8925fab1071a3b670deff6de2f4f4fb
Signed-off-by: Amador Pahim <apahim(a)redhat.com&gt;
---
M vdsm/API.py
M vdsm/ksm.py
2 files changed, 21 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/4614/1
--
To view, visit http://gerrit.ovirt.org/4614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5948b4eb8925fab1071a3b670deff6de2f4f4fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com&gt;

Amador Pahim has abandoned this change.

Change subject: Adding KSM pages_shared and pages_sharing stats (in MBytes).
......................................................................


Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/4614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id5948b4eb8925fab1071a3b670deff6de2f4f4fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;

Mark Wu has posted comments on this change.

Change subject: Adding KSM pages_shared and pages_sharing stats (in MBytes).
......................................................................


Patch Set 1: I would prefer that you didn't submit this

This patch is helpful for users to know how much memory is saved by KSM and it's more
accurate than the existing 'memShared'.  I think we needn't wait for the MOM
integration patch to consider this one. Because, the MOM integration patch doesn't
change how ksmMonitor works. It just moves KSM tuning and stats reporting function to MOM
and falls back to ksmMonitor if MOM is not available. So this patch doesn't have any
dependency on the MOM integration patch. 

But the patch itself, it seems that it can't reflect actual KSM stats in time, because
the result is retrieved when  adjust() is called, not the time getStats() is invoked.
Perhaps there's a big difference of them because of the KSM work.

--
To view, visit http://gerrit.ovirt.org/4614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5948b4eb8925fab1071a3b670deff6de2f4f4fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Adding KSM pages_shared and pages_sharing stats (in MBytes).
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Agreed,let's wait. Thanks Amador!

--
To view, visit http://gerrit.ovirt.org/4614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5948b4eb8925fab1071a3b670deff6de2f4f4fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;

Amador Pahim has posted comments on this change.

Change subject: Adding KSM pages_shared and pages_sharing stats (in MBytes).
......................................................................


Patch Set 1:

No background information from engine up to now. There is a BZ (732464) discussing RHEVM
"Shared Memory" results. I agree would be great to have KSM memory share stats.
This patch aims to create the foundation to engine further work. Not a big deal resubmit
it after Mark Wu work, if still needed.

--
To view, visit http://gerrit.ovirt.org/4614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5948b4eb8925fab1071a3b670deff6de2f4f4fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Adding KSM pages_shared and pages_sharing stats (in MBytes).
......................................................................


Patch Set 1: I would prefer that you didn't submit this

could you provide some background on why this new information needed? Is Engine about to
collect it?

Note that there is another patch by Mark Wu, that is changing how ksmmonitor is to be
used. we may need to collect the information in another place.

--
To view, visit http://gerrit.ovirt.org/4614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5948b4eb8925fab1071a3b670deff6de2f4f4fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;