From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: python3: Fix UUID packing/unpacking on python 3 ......................................................................
Patch Set 9: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/78632/9/tests/storage/misc_test.py File tests/storage/misc_test.py:
Line 453: Line 454: Line 455: class TestUuidPack(VdsmTestCase): Line 456: Line 457: def test(self): this test is not good enough for this refactoring: you'd probably want to prove that you do not change existing packing.
please consider adding such a test before merging. Line 458: """ Line 459: Test that the uuid that was packed can be unpacked without being Line 460: changed Line 461: """
PS9, Line 463: uuid.uuid4() unrelated to this patch: randomness in tests is a liability. if this test fails once in a million, we would not notice.
vdsm-patches@lists.fedorahosted.org