From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: python3: Fix UUID packing/unpacking on python 3
......................................................................
Patch Set 9: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/78632/9/tests/storage/misc_test.py
File tests/storage/misc_test.py:
Line 453:
Line 454:
Line 455: class TestUuidPack(VdsmTestCase):
Line 456:
Line 457: def test(self):
this test is not good enough for this refactoring: you'd probably want to prove that
you do not change existing packing.
please consider adding such a test before merging.
Line 458: """
Line 459: Test that the uuid that was packed can be unpacked without being
Line 460: changed
Line 461: """
PS9, Line 463: uuid.uuid4()
unrelated to this patch: randomness in tests is a liability. if this test fails once in a
million, we would not notice.
--
To view, visit
https://gerrit.ovirt.org/78632
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41cfa5e54e76dfcad267792daebc54e80bf2a022
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes