Dan Kenigsberg has posted comments on this change.
Change subject: fix error handling for misc.NoIntrPoll
......................................................................
Patch Set 3: (1 inline comment)
....................................................
Commit Message
Line 10: and epoll raise OSError.
Line 11: tested poll/epoll, pipe/file, closed pipe/pipe buffer overflow
Line 12: pipe write/read end error will not raise poll error.
Line 13: Found in:
Line 14:
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/170/
here's another manifestation at
http://jenkins.ovirt.org/job/vdsm_unit_tests/1668/testReport/junit/remote...
:
Traceback (most recent call last):
File "/usr/lib64/python2.7/unittest/case.py", line 365, in run
testMethod()
File
"/home/jenkins/workspace/vdsm_unit_tests/tests/remoteFileHandlerTests.py", line
54, in testRegeneration
self.testEcho()
File
"/home/jenkins/workspace/vdsm_unit_tests/tests/remoteFileHandlerTests.py", line
41, in testEcho
self.assertEquals(self.pool.callCrabRPCFunction(1, "echo", data), data)
File
"/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
line 280, in callCrabRPCFunction
*args, **kwargs)
File
"/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
line 191, in callCrabRPCFunction
raise Timeout()
Timeout:
-------------------- >> begin captured logging << --------------------
Storage.CrabRPCProxy: ERROR: Problem with handler, treating as timeout
Traceback (most recent call last):
File
"/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
line 180, in callCrabRPCFunction
rawLength = self._recvAll(LENGTH_STRUCT_LENGTH, timeout)
File
"/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
line 149, in _recvAll
timeLeft):
File "/usr/lib64/python2.7/contextlib.py", line 84, in helper
return GeneratorContextManager(func(*args, **kwds))
File
"/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
line 133, in _poll
res = misc.NoIntrPoll(self._poller.poll, timeout)
File "/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/misc.py", line
1348, in NoIntrPoll
return pollfun(timeout)
error: (4, 'Interrupted system call')
--------------------- >> end captured logging << ---------------------
Line 15:
Line 16: Change-Id: I272654a9006fdab77e5fab608ac287416d75843e
--
To view, visit
http://gerrit.ovirt.org/9458
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I272654a9006fdab77e5fab608ac287416d75843e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server