Change in vdsm[master]: Move guest agent timeout config reading to clientIF.__init__

Saggi Mizrahi has uploaded a new change for review.

Change subject: Move guest agent timeout config reading to clientIF.__init__
......................................................................

Move guest agent timeout config reading to clientIF.__init__

Change-Id: Id6138f2b47934cb8afc89cd9a2d14867d9db03a9
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
---
M vdsm/clientIF.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/9396/1

diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 82603af..73fe3c0 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -66,6 +66,7 @@
         :param log: a log object to be used for this object's logging.
         :type log: :class:`logging.Logger`
         """
+        self.guestAgentTimeout = config.getint('vars',
'guest_agent_timeout')
         self.vmContainerLock = threading.Lock()
         self._networkSemaphore = threading.Semaphore()
         self._shutdownSemaphore = threading.Semaphore()
@@ -100,8 +101,7 @@
             self._prepareMOM()
             threading.Thread(target=self._recoverExistingVms,
                              name='clientIFinit').start()
-            self.channelListener.settimeout(
-                    config.getint('vars', 'guest_agent_timeout'))
+            self.channelListener.settimeout(self.guestAgentTimeout)
             self.channelListener.start()
             self.threadLocal = threading.local()
             self.threadLocal.client = ''


--
To view, visit http://gerrit.ovirt.org/9396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6138f2b47934cb8afc89cd9a2d14867d9db03a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has abandoned this change.

Change subject: Move guest agent timeout config reading to clientIF.__init__
......................................................................


Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/9396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id6138f2b47934cb8afc89cd9a2d14867d9db03a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move guest agent timeout config reading to clientIF.__init__
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/clientIF.py
Line 99
Line 100
Line 101
Line 102
Line 103
this is already read (and used) in __init__ only.
why do we need it as a (public) data member? your commit message does not give a hint.


--
To view, visit http://gerrit.ovirt.org/9396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6138f2b47934cb8afc89cd9a2d14867d9db03a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move guest agent timeout config reading to clientIF.__init__
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/94/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/128/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6138f2b47934cb8afc89cd9a2d14867d9db03a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move guest agent timeout config reading to clientIF.__init__
......................................................................


Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/94/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6138f2b47934cb8afc89cd9a2d14867d9db03a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move guest agent timeout config reading to clientIF.__init__
......................................................................


Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/128/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6138f2b47934cb8afc89cd9a2d14867d9db03a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server