Change in vdsm[ovirt-3.3]: sos: plugin should ignore /var/run/vdsm/storage

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: sos: plugin should ignore /var/run/vdsm/storage
......................................................................

sos: plugin should ignore /var/run/vdsm/storage

In case sos plugin includes /var/run/vdsm/storage and it contains
symlinks to block devices it can make the host fill the disk
and eventually create a 0 sized sosreport.

Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
---
M vdsm/sos/vdsm.py.in
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/23930/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 63a028c..6e4e60b 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -120,5 +120,6 @@
         import glob
 
         for f in glob.glob("@VDSMRUNDIR@/*"):
-            if not f.endswith('.vfd') and not
f.endswith('/isoUploader'):
+            if not f.endswith('.vfd') and not f.endswith('/isoUploader')
\
+                    and not f.endswith('/storage'):
                 self.addCopySpec(f)


-- 
To view, visit http://gerrit.ovirt.org/23930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: sos: plugin should ignore /var/run/vdsm/storage
......................................................................


Patch Set 1:

please backport to ovirt-3.4 before doing so to ovirt-3.3.

-- 
To view, visit http://gerrit.ovirt.org/23930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-HasComments: No

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: sos: plugin should ignore /var/run/vdsm/storage
......................................................................


sos: plugin should ignore /var/run/vdsm/storage

In case sos plugin includes /var/run/vdsm/storage and it contains
symlinks to block devices it can make the host fill the disk
and eventually create a 0 sized sosreport.

Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/23930
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/sos/vdsm.py.in
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: sos: plugin should ignore /var/run/vdsm/storage
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/23930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-HasComments: No

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: sos: plugin should ignore /var/run/vdsm/storage
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/23930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-HasComments: No