Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23718
to review the following change.
Change subject: vdsm.spec: vdsm should own vdsm.log
......................................................................
vdsm.spec: vdsm should own vdsm.log
/var/log/vdsm/vdsm.log should be owned by VDSM.
Change-Id: Id12a78f3243138cd95a13cc7c8a8d3d499ceee4a
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1055153
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/23696
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/23718/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 7912635..da6e45e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -610,6 +610,11 @@
rm -rf %{buildroot}
make DESTDIR=%{buildroot} install
+# VDSM Log
+install -dDm 0755 %{buildroot}@VDSMLOGDIR@
+# Avoid rpmbuild complain about vdsm.log doesn't exist during the build
+touch %{buildroot}@VDSMLOGDIR(a)/vdsm.log
+
# Install the respawn utility
install -Dm 0755 init/sysvinit/respawn \
%{buildroot}%{_datadir}/%{vdsm_name}/respawn
@@ -874,6 +879,7 @@
%endif
%dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@
+%ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR(a)/vdsm.log
%ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/hsm-tasks
%ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/mnt
%dir %{_libexecdir}/%{vdsm_name}
--
To view, visit
http://gerrit.ovirt.org/23718
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id12a78f3243138cd95a13cc7c8a8d3d499ceee4a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>