10:02 a.m.
mooli tayer has uploaded a new change for review.
Change subject: tool: remove unused NotRootError.
......................................................................
tool: remove unused NotRootError.
Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M lib/vdsm/tool/configurators/libvirt.py
M lib/vdsm/tool/configurators/sanlock.py
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/32256/1
diff --git a/lib/vdsm/tool/configurators/libvirt.py
b/lib/vdsm/tool/configurators/libvirt.py
index 0f88b32..1b7556b 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -27,7 +27,6 @@
from vdsm.config import config
from .. import \
- NotRootError, \
service, \
validate_ovirt_certs
from . import \
diff --git a/lib/vdsm/tool/configurators/sanlock.py
b/lib/vdsm/tool/configurators/sanlock.py
index 0c847a3..1c2b3dd 100644
--- a/lib/vdsm/tool/configurators/sanlock.py
+++ b/lib/vdsm/tool/configurators/sanlock.py
@@ -21,7 +21,6 @@
import grp
import pwd
-from .. import NotRootError
from .import \
CONFIGURED, \
InvalidConfig, \
--
To view, visit http://gerrit.ovirt.org/32256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
10:42 a.m.
New subject: Change in vdsm[master]: tool: fix pyflakes errors[1].
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: fix pyflakes errors[1].
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11249/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12191/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12038/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:41 a.m.
New subject: Change in vdsm[master]: tool: fix pyflakes errors[1].
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: fix pyflakes errors[1].
......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5770/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/135/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3929/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1794/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/32256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:36 a.m.
New subject: Change in vdsm[master]: tool: fix pyflakes errors[1].
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tool: fix pyflakes errors[1].
......................................................................
tool: fix pyflakes errors[1].
recently I broke master at change 31293.
[1]
./lib/vdsm/tool/configurators/libvirt.py:29: 'NotRootError' imported but unused
./lib/vdsm/tool/configurators/sanlock.py:24: 'NotRootError' imported but unused
Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32256
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurators/libvirt.py
M lib/vdsm/tool/configurators/sanlock.py
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
mooli tayer: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:36 a.m.
New subject: Change in vdsm[master]: tool: fix pyflakes errors[1].
Dan Kenigsberg has posted comments on this change.
Change subject: tool: fix pyflakes errors[1].
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:19 a.m.
New subject: Change in vdsm[master]: tool: fix pyflakes errors[1].
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: fix pyflakes errors[1].
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11248/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12190/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12037/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:16 a.m.
New subject: Change in vdsm[master]: tool: fix pyflakes errors[1].
mooli tayer has posted comments on this change.
Change subject: tool: fix pyflakes errors[1].
......................................................................
Patch Set 2: Verified+1
on el6.5.
Make check passes fine.
--
To view, visit http://gerrit.ovirt.org/32256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:08 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: remove unused NotRootError.
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11247/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12189/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12036/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3532
days inactive
3532
days old
vdsm-patches@lists.fedorahosted.org
7 comments
3 participants
participants (3)
-
Dan Kenigsberg -
Jenkins CI RO -
mtayer＠redhat.com