4:27 p.m.
Hello mooli tayer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32205
to review the following change.
Change subject: Use stdout for regular output message in removeConf func
......................................................................
Use stdout for regular output message in removeConf func
Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31941
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/32205/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 83e7d41..6d497ae 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -154,7 +154,7 @@
for c in args.modules:
try:
c.removeConf()
- sys.stderr.write(
+ sys.stdout.write(
"removed configuration of module %s successfully\n" %
c.getName()
)
--
To view, visit http://gerrit.ovirt.org/32205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
10:26 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Use stdout for regular output message in removeConf func
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/128/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 a.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Use stdout for regular output message in removeConf func
......................................................................
Use stdout for regular output message in removeConf func
Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31941
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32205
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Bronhaim: Verified; Looks good to me, approved
mooli tayer: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
9 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Use stdout for regular output message in removeConf func
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
8:34 a.m.
mooli tayer has posted comments on this change.
Change subject: Use stdout for regular output message in removeConf func
......................................................................
Patch Set 1: Code-Review+1
clean cherry pick from master
--
To view, visit http://gerrit.ovirt.org/32205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
4:27 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Use stdout for regular output message in removeConf func
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
3532
days inactive
3533
days old
vdsm-patches@lists.fedorahosted.org
5 comments
3 participants
participants (3)
-
Jenkins CI RO -
mtayer＠redhat.com -
ybronhei＠redhat.com