Change in vdsm[master]: Support stable PCI address for uknown general devices

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Support stable PCI address for uknown general devices
......................................................................

Support stable PCI address for uknown general devices

Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 117 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/1040/1
--
To view, visit http://gerrit.ovirt.org/1040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Support stable PCI address for uknown general devices
......................................................................


Support stable PCI address for uknown general devices

Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 119 insertions(+), 17 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Verified


--
To view, visit http://gerrit.ovirt.org/1040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Support stable PCI address for uknown general devices
......................................................................


Patch Set 5: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Support stable PCI address for uknown general devices
......................................................................


Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/1040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Support stable PCI address for uknown general devices
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1521:         Unknown device is a device that has an address but manager wasn't
but wasn't passed (by Engine) during...

Line 1532:             knownDev = False
def getDeviceByAlias(alias)

would be prettier

--
To view, visit http://gerrit.ovirt.org/1040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Support stable PCI address for uknown general devices
......................................................................


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/1040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;