Dan Kenigsberg has posted comments on this change.
Change subject: Support stable PCI address for controller devices
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
few questions
....................................................
File vdsm/libvirtvm.py
Line 820: ctrl.setAttribute('index', '0')
how about making this ever so slightly more general and passing these in the constructor?
....................................................
File vdsm/vm.py
Line 61: setattr(self, attr, value)
sorry to have noticed this only now, but shouldn't we disallow overriding existing
attr like .log, conf, __doc__ ?
Line 420: Normalize controller device provided by conf.
self.conf has nothign to do with this function...
--
To view, visit
http://gerrit.ovirt.org/1039
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If69b39fd4d801043763160efbccafdc49b5eabf0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>