Change in vdsm[master]: connectivity log: report if Engine has been seen recently

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................

connectivity log: report if Engine has been seen recently

Vdsm monitors when it has been accessed by a client (most probably
Engine). If Vdsm finds out that it has suddenly seized to be accessed
for the last 30 seconds (twice the Engine polling rate),
"recent_client:False" is logged to the connectivity.log. When polling is
restored, "recent_client:True" is reported.

Bug-Url: https://bugzilla.redhat.com/1111234
Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/virt/sampling.py
1 file changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/30226/1

diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 98f705c..26d670a 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -37,7 +37,7 @@
 from vdsm import utils
 from vdsm import netinfo
 from vdsm.ipwrapper import getLinks
-from vdsm.constants import P_VDSM_RUN
+from vdsm.constants import P_VDSM_RUN, P_VDSM_CLIENT_LOG
 
 import caps
 
@@ -279,11 +279,16 @@
             self.thpState = 'never'
         self.cpuCores = CpuCoreSample()
         self.numaNodeMem = NumaNodeMemorySample()
+        TYPICAL_CLIENT_POLL_INTERVAL = 15
+        self.recentClient = (
+            self.timestamp - os.stat(P_VDSM_CLIENT_LOG).st_mtime <
+            2 * TYPICAL_CLIENT_POLL_INTERVAL)
 
     def to_connlog(self):
-        return ', '.join(
+        text = ', '.join(
             ('%s:(%s)' % (ifid, ifacesample.to_connlog()))
             for (ifid, ifacesample) in self.interfaces.iteritems())
+        return ('recent_client:%s, ' % self.recentClient) + text
 
     def connlog_diff(self, other):
         text = ''
@@ -294,6 +299,10 @@
                     text += '%s:(%s) ' % (ifid, diff)
             else:
                 text += 'new %s:(%s) ' % (ifid, sample.to_connlog())
+
+        if self.recentClient != other.recentClient:
+            text += 'recent_client:%s' % self.recentClient
+
         return text
 
 


-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5631/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3789/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1649/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


connectivity log: report if Engine has been seen recently

Vdsm monitors when it has been accessed by a client (most probably
Engine). If Vdsm finds out that it has not been accessed for the last 30
seconds (twice the Enginei's polling rate), "recent_client:False" is
logged to the connectivity.log. When polling is restored,
"recent_client:True" is reported.

Bug-Url: https://bugzilla.redhat.com/1111234
Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/30226
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Reviewed-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/virt/sampling.py
1 file changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10322/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11107/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1334/ : There was an
infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11264/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Antoni Segura Puimedon has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10320/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11105/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1332/ : There was an
infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11262/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 2: Verified+1

log shows 

 2014-07-18 14:40:43,980:DEBUG:  recent_client:False

30 seconds after client stops.

-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/30226/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 278:         except:
Line 279:             self.thpState = 'never'
Line 280:         self.cpuCores = CpuCoreSample()
Line 281:         self.numaNodeMem = NumaNodeMemorySample()
Line 282:         TYPICAL_CLIENT_POLL_INTERVAL = 15
>  maybe better: ENGINE_DEFAULT_POLL_INTERVAL 
I don't know
which name is better. But whenever in doubt - do what the reviewer suggests.
Line 283:         self.recentClient = (
Line 284:             self.timestamp - os.stat(P_VDSM_CLIENT_LOG).st_mtime <
Line 285:             2 * TYPICAL_CLIENT_POLL_INTERVAL)
Line 286: 


-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Antoni Segura Puimedon has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.ovirt.org/#/c/30226/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: connectivity log: report if Engine has been seen recently
Line 8: 
Line 9: Vdsm monitors when it has been accessed by a client (most probably
Line 10: Engine). If Vdsm finds out that it has suddenly seized to be accessed
maybe more readable:
"If Vdsm finds out that it has not been accessed for the past 30 seconds"
Line 11: for the last 30 seconds (twice the Engine polling rate),
Line 12: "recent_client:False" is logged to the connectivity.log. When polling
is
Line 13: restored, "recent_client:True" is reported.
Line 14: 


http://gerrit.ovirt.org/#/c/30226/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 278:         except:
Line 279:             self.thpState = 'never'
Line 280:         self.cpuCores = CpuCoreSample()
Line 281:         self.numaNodeMem = NumaNodeMemorySample()
Line 282:         TYPICAL_CLIENT_POLL_INTERVAL = 15
maybe better: ENGINE_DEFAULT_POLL_INTERVAL
Line 283:         self.recentClient = (
Line 284:             self.timestamp - os.stat(P_VDSM_CLIENT_LOG).st_mtime <
Line 285:             2 * TYPICAL_CLIENT_POLL_INTERVAL)
Line 286: 


-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: connectivity log: report if Engine has been seen recently
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10307/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11092/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1326/ : There was an
infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11249/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/30226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No