Dan Kenigsberg has posted comments on this change.
Change subject: connectivity log: report if Engine has been seen recently
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/30226/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 278: except:
Line 279: self.thpState = 'never'
Line 280: self.cpuCores = CpuCoreSample()
Line 281: self.numaNodeMem = NumaNodeMemorySample()
Line 282: TYPICAL_CLIENT_POLL_INTERVAL = 15
maybe better: ENGINE_DEFAULT_POLL_INTERVAL
I don't know
which name is better. But whenever in doubt - do what the reviewer suggests.
Line 283: self.recentClient = (
Line 284: self.timestamp - os.stat(P_VDSM_CLIENT_LOG).st_mtime <
Line 285: 2 * TYPICAL_CLIENT_POLL_INTERVAL)
Line 286:
--
To view, visit
http://gerrit.ovirt.org/30226
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice088421d82f60e59ada6e743aeac2704c44cb7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes