Change in vdsm[master]: config: Resolve crash when IPv6 disabled in kernel

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: config: Resolve crash when IPv6 disabled in kernel
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/47978/1/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 102:         self._addSourceRoute(bridge)
Line 103:         _ifup(bridge)
Line 104: 
Line 105:         # Check if ipv6 is disabled by kernel arguments
Line 106:         has_ipv6 = True
hmm, I think that we'd better expose this as a memoized function in caps.py, and in
the output of getCaps. Otherwise Engine would not know if we support ipv6 or not.
Line 107:         try:
Line 108:             socket.socket(socket.AF_INET6, socket.SOCK_DGRAM)
Line 109:         except socket.error:
Line 110:             has_ipv6 = False


-- 
To view, visit https://gerrit.ovirt.org/47978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774cac868ddee08ac072adf2104a811594779052
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ollie Armstrong <ollie(a)fubra.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes