Change in vdsm[master]: net: use libvirt to manage bridge mac learning

Ido Barkan has uploaded a new change for review.

Change subject: net: use libvirt to manage bridge mac learning
......................................................................

net: use libvirt to manage bridge mac learning

In late kernels, this can lead for performance boost, by eliminating
unneeded packet flooding in the LAN and also allow the kernel to shut
down promiscuous mode for bridge ports.
see: https://libvirt.org/formatnetwork.html#elementsConnect

Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4
Signed-off-by: Ido Barkan <ibarkan(a)redhat.com&gt;
---
M vdsm/network/configurators/libvirt.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/47935/1

diff --git a/vdsm/network/configurators/libvirt.py
b/vdsm/network/configurators/libvirt.py
index a88ded7..85490ba 100644
--- a/vdsm/network/configurators/libvirt.py
+++ b/vdsm/network/configurators/libvirt.py
@@ -46,7 +46,8 @@
     <network>
         <name>vdsm-awesome_net</name>
 
-        <forward mode='bridge'/><bridge name='awesome_net'/>
||
+        <forward mode='bridge'/>
+            <bridge name='awesome_net'
macTableManager="libvirt"/> ||
         <forward mode='passthrough'><interface
dev='incredible'/></forward>
     </network>
 
@@ -54,6 +55,8 @@
     according to net if bridged or bridgeless this
     determines respectively the presence of bridge element
     or interface subelement.
+    For bridged networks, libvirt can manage the forwarding table of the
+    bridge, which can enhance performance for the host.
     """
 
     netName = netinfo.LIBVIRT_NET_PREFIX + network
@@ -75,7 +78,8 @@
     root.append(nameElem)
     root.append(forwardElem)
     if bridged:
-        root.append(EtreeElement('bridge', name=network))
+        root.append(
+            EtreeElement('bridge', name=network,
macTableManager='libvirt'))
     else:
         forwardElem.append(EtreeElement('interface', dev=iface))
     return etree.tostring(root)


-- 
To view, visit https://gerrit.ovirt.org/47935
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: net: use libvirt to manage bridge mac learning
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47935
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: net: use libvirt to manage bridge mac learning
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47935
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: net: use libvirt to manage bridge mac learning
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/47935/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: In late kernels, this can lead for performance boost, by eliminating
Line 10: unneeded packet flooding in the LAN and also allow the kernel to shut
Line 11: down promiscuous mode for bridge ports.
Line 12: see: https://libvirt.org/formatnetwork.html#elementsConnect
shouldn't we require a newer kernel in the spec file? a newer libvirt?
Line 13: 
Line 14: Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4


https://gerrit.ovirt.org/#/c/47935/2/vdsm/network/configurators/libvirt.py
File vdsm/network/configurators/libvirt.py:

Line 46:     <network>
Line 47:         <name>vdsm-awesome_net</name>
Line 48: 
Line 49:         <forward mode='bridge'/>
Line 50:             <bridge name='awesome_net'
macTableManager="libvirt"/> ||
If this is hard-coded I think that we won't be able to implement

 Bug 1193224 - [RFE] disable (or better, choose) filter per vNIC profile

so I think that we must expose this as a knob when setting up a network.
Line 51:         <forward mode='passthrough'><interface
dev='incredible'/></forward>
Line 52:     </network>
Line 53: 
Line 54:     Forward mode can be either bridge or passthrough,


-- 
To view, visit https://gerrit.ovirt.org/47935
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes

automation(a)ovirt.org has posted comments on this change.

Change subject: net: use libvirt to manage bridge mac learning
......................................................................


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47935
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No