From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: handle password-less login properly
......................................................................
v2v: handle password-less login properly
Import methods from KVM that do not require password were not handled
properly. We receive None from the engine in user name/password fields
which caused unhandled exception when writing the password file.
Further, in case of KVM import, there is no reason to pass the empty
user name/password to kvm2ovirt tool at all.
Bug-Url:
https://bugzilla.redhat.com/1388596
Change-Id: If0bb8055c87d83600442fc40b5597fbe04fbce2f
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M lib/vdsm/v2v.py
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit
https://gerrit.ovirt.org/67081
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0bb8055c87d83600442fc40b5597fbe04fbce2f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>