Deepak C Shetty has posted comments on this change.
Change subject: nfs-check improvements
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File contrib/nfs-check.py
Line 181: process = cmdRet[0]
Done
Line 238: errorMsg = process.communicate()[1].strip()
Can you provide some error example where the whitespaces are useful ?
Also removing the strip() causes the output as below ( when i simulated a error) ...
python nfs-check.py llm19.in.ibm.com:/tmp/nfstest
Current hostname:
llm65.in.ibm.com - IP addr 9.124.111.96
Trying to /bin/mount -t nfs llm19.in.ibm.com:/tmp/nfstest...
Executing NFS tests..
Permission denied: vdsm user as kvm cannot create a file into /tmp/tmpRsr5ZV
Suggestions: please verify the permissions of target (chmod or/and selinux booleans)
return = 1 error msg = /bin/touch: cannot touch `/tmp/tmpRsr5ZV/vdsmTest': Permission
denied
Status of tests [Failed]
For more troubleshooting tips, visit
http://www.ovirt.org/wiki/Troubleshooting_NFS_Storage_Issues
Disconnecting from NFS Server..
Done!
Notice the extra blank line just above "Status of tests [Failed]", which is not
looking too good. I think thats caused due to the \n present at the end of the errorMsg
and python print also adds \n.
Assuming there are instances where whitespaces might be needed in errorMsg,
i will remove strip() from the func, but still use it for all errorMsg reporting, so that
we don't see the extra newline as above. Hope that is ok.
Line 247: return cmdRet
Done
--
To view, visit
http://gerrit.ovirt.org/3081
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I939476dbbad0f97b43b8dff4dc2c5913cb3d1a1e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>