4:29 p.m.
Nir Soffer has uploaded a new change for review.
Change subject: log: Nicer logging format
......................................................................
log: Nicer logging format
Use nicer and more standard logging format, similar to engine log
format. Having similar logging formats should make it easier to debug
and support.
Here is an example log using the new format:
2016-09-19 00:02:25,291 INFO [vds] (MainThread) (PID: 10281) I am the actual vdsm
4.18.999-578.git61bfe00.el7 voodoo6.tlv.redhat.com (3.10.0-489.el7.x86_64)
2016-09-19 00:02:25,291 INFO [vds] (MainThread) VDSM will run with cpu affinity:
frozenset([1])
2016-09-19 00:02:25,379 INFO [storage.check] (MainThread) Starting check service
2016-09-19 00:02:25,384 INFO [storage.Dispatcher] (MainThread) Starting
StorageDispatcher...
2016-09-19 00:02:25,385 INFO [storage.asyncevent] (check/loop) Starting <EventLoop
running=True closed=False at 0x33716496>
2016-09-19 00:02:25,482 INFO [dispatcher] (MainThread) Run and protect:
registerDomainStateChangeCallback(callbackFunc=<functools.partial object at
0x288f260>)
2016-09-19 00:02:25,482 INFO [dispatcher] (MainThread) Run and protect:
registerDomainStateChangeCallback, Return response: None
2016-09-19 00:02:25,485 INFO [MOM] (MainThread) Preparing MOM interface
2016-09-19 00:02:25,486 INFO [MOM] (MainThread) Using named unix socket
/var/run/vdsm/mom-vdsm.sock
2016-09-19 00:02:25,487 INFO [root] (MainThread) Unregistering all secrets
2016-09-19 00:02:25,491 INFO [vds] (MainThread) Setting channels' timeout to 30
seconds.
2016-09-19 00:02:25,493 INFO [vds.MultiProtocolAcceptor] (MainThread) Listening at
:::54321
2016-09-19 00:02:25,526 INFO [vds] (clientIFinit) recovery: completed in 0s
2016-09-19 00:02:25,560 WARNING [storage.Multipath] (hsm/init) Map
'360014052c81462a280847e8a6e3af8cd' has no slaves
2016-09-19 00:02:25,560 WARNING [storage.Multipath] (hsm/init) Map
'36001405292bb96f19064f81b884fa63f' has no slaves
2016-09-19 00:02:27,115 INFO [vds] (BindingXMLRPC) XMLRPC server running
2016-09-19 00:02:27,122 INFO [health] (MainThread) Starting health monitor
(interval=60)
2016-09-19 00:02:40,256 INFO [ProtocolDetector.AcceptorImpl] (Reactor thread) Accepting
connection from ::1:42888
2016-09-19 00:02:40,270 INFO [ProtocolDetector.Detector] (Reactor thread) Detected
protocol xml from ::1:42888
2016-09-19 00:02:40,270 INFO [vds.XMLRPCServer] (BindingXMLRPC) Starting request
handler for ::1:42888
2016-09-19 00:02:40,271 INFO [vds.XMLRPCServer] (Thread-12) Request handler for
::1:42888 started
2016-09-19 00:02:40,272 INFO [throttled] (Thread-12) Current getAllVmStats: {}
2016-09-19 00:02:40,272 INFO [vds] (Thread-12) RPC call getAllVmStats finished (code=0)
in 0.00 seconds
Unfinished: require updating all the tools parsing vdsm log.
Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M static/etc/vdsm/logger.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/64113/1
diff --git a/static/etc/vdsm/logger.conf.in b/static/etc/vdsm/logger.conf.in
index 34137ff..820fcb4 100644
--- a/static/etc/vdsm/logger.conf.in
+++ b/static/etc/vdsm/logger.conf.in
@@ -86,7 +86,7 @@
format: %(message)s
[formatter_long]
-format:
%(threadName)s::%(levelname)s::%(asctime)s::%(module)s::%(lineno)d::%(name)s::(%(funcName)s)
%(message)s
+format: %(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) %(message)s
[formatter_sysform]
format= vdsm %(name)s %(levelname)s %(message)s
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
4:29 p.m.
gerrit-hooks has posted comments on this change.
Change subject: log: Nicer logging format
......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2:08 a.m.
Francesco Romani has posted comments on this change.
Change subject: log: Nicer logging format
......................................................................
Patch Set 1: Code-Review+1
I like this. We tried to change our log format in the past, without much luck. Let's
try again.
There is a high chance this will break scripts/tools from GSS/QE/users, however, perhaps
better advertise this ad give the users plenty of time to upgrade.
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6:09 a.m.
Nir Soffer has posted comments on this change.
Change subject: log: Nicer logging format
......................................................................
Patch Set 1:
Maybe we need to have a library for parsing vdsm logs. We already have this code in some
tools (e.g contrib/db). This will make it easy for people, they can use the current vdsm
log parser and do not worry.
We cannot help people parsing logs with grep/awk etc. The only option to support this is
to never change anything and keep the current horrible format.
I'll update logdb and other tools that depend on the logs if we have agreement to go
in this direction.
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6:15 a.m.
Francesco Romani has posted comments on this change.
Change subject: log: Nicer logging format
......................................................................
Patch Set 1:
I for myself support this direction. This format is much much nicer and easier to work
with.
The idea to have a log parser helper is also very nice.
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:17 p.m.
Nir Soffer has posted comments on this change.
Change subject: log: Nicer logging format
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2:29 a.m.
Piotr Kliczewski has posted comments on this change.
Change subject: log: Nicer logging format
......................................................................
Patch Set 1:
Do we know whether anyone already parses our log to collect information about what is
going on?
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
9:49 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: log: Nicer logging format
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64113/1/static/etc/vdsm/logger.conf.in
File static/etc/vdsm/logger.conf.in:
Line 85: [formatter_none]
Line 86: format: %(message)s
Line 87:
Line 88: [formatter_long]
Line 89: format: %(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) %(message)s
please add the module:lineno, it helps me a lot.
Line 90:
Line 91: [formatter_sysform]
Line 92: format= vdsm %(name)s %(levelname)s %(message)s
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
10:51 a.m.
New subject: Change in vdsm[master]: log: More standard logging format
gerrit-hooks has posted comments on this change.
Change subject: log: More standard logging format
......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
11:53 a.m.
New subject: Change in vdsm[master]: log: More standard logging format
Nir Soffer has posted comments on this change.
Change subject: log: More standard logging format
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:47 p.m.
New subject: Change in vdsm[master]: logging: More standard logging format
gerrit-hooks has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:47 p.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Nir Soffer has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:55 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Michal Skrivanek has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 3: Code-Review-1
I would hate to see the thread id somewhere deep, it is THE most critical thing to follow
(it doesn't have to be first, timestamp does make sense, but it needs to be at the
start somewhere and aligned)
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
4:05 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Milan Zamazal has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 3: Code-Review+1
Thanks for putting module:lineno back. It's fine for me as it is now (as well as if
Michal's comment is considered).
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6:27 p.m.
New subject: Change in vdsm[master]: logging: More standard logging format
gerrit-hooks has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6:28 p.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Nir Soffer has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4: Verified+1
This version moves the thread name before the logger name and include the example log in
the commit message.
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:56 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Michal Skrivanek has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
10:13 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Peter Portante has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4:
Hope you don't mind a comment from an outsider...
These kinds of changes to make formatting of log output "pretty" tie the
visualizations of logs to the log emitter, which can be less flexible than you might want
in the future.
Have you considered keeping the format of how logs are emitted separate from how they are
displayed so that they can iterate at their own rate and their concerns not be
intertwined?
Perhaps a JSON format output and write a simple viewer that consumes that, or use an
existing one?
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
12:06 p.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Nir Soffer has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4:
Thanks Peter, I think this is an interesting idea.
For the common use case textual logs work fine. For some cases,
like consuming the logs by a program, the current log is pretty
bad.
For example, the repoplot tool:
- https://github.com/oVirt/vdsm/blob/master/contrib/repoplot
- https://bugzilla.redhat.com/1081962 (look for repoplot)
Having structured logs can help, but is not enough, the logs must
be designed to support such usage and treated like an api, and
we can do this using textual logs.
To make it easier to follow operations, we added logs when operation
starts and finish, for example (look for START and FINISH):
- https://github.com/oVirt/vdsm/blob/master/lib/vdsm/common/api.py
- https://github.com/oVirt/vdsm/blob/master/lib/vdsm/storage/check.py
I think we should discuss this later in the context of the entire
ovirt project.
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:21 p.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Nir Soffer has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4:
ping
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
12:31 p.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Francesco Romani has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:14 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Piotr Kliczewski has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2:29 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Edward Haas has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:23 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Dan Kenigsberg has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 4: Code-Review+2
ok, let's do it.
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:23 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: More standard logging format
......................................................................
logging: More standard logging format
Use nicer and more standard logging format, similar to engine log
format. Having similar logging formats in the oVirt project should make
it easier to debug and support.
Changes compared to engine log:
- (thread-name) is displayed before the [logger-name] so it is always
aligned.
- Add (module:lineno) at the end of the message.
Here is example log during vdsm startup:
2016-09-23 02:11:43,319 INFO (MainThread) [vds] (PID: 19841) I am the actual vdsm
4.18.999-604.gitf69ba3a.el7 voodoo6.tlv.redhat.com (3.10.0-489.el7.x86_64) (vdsm:145)
2016-09-23 02:11:43,319 INFO (MainThread) [vds] VDSM will run with cpu affinity:
frozenset([1]) (vdsm:251)
2016-09-23 02:11:43,385 INFO (MainThread) [storage.check] Starting check service
(check:91)
2016-09-23 02:11:43,389 INFO (MainThread) [storage.Dispatcher] Starting
StorageDispatcher... (dispatcher:47)
2016-09-23 02:11:43,389 INFO (check/loop) [storage.asyncevent] Starting <EventLoop
running=True closed=False at 0x50437200> (asyncevent:122)
2016-09-23 02:11:43,480 INFO (MainThread) [dispatcher] Run and protect:
registerDomainStateChangeCallback(callbackFunc=<functools.partial object at
0x3877a48>) (logUtils:49)
2016-09-23 02:11:43,480 INFO (MainThread) [dispatcher] Run and protect:
registerDomainStateChangeCallback, Return response: None (logUtils:52)
2016-09-23 02:11:43,481 INFO (MainThread) [MOM] Preparing MOM interface (momIF:49)
2016-09-23 02:11:43,481 INFO (MainThread) [MOM] Using named unix socket
/var/run/vdsm/mom-vdsm.sock (momIF:58)
2016-09-23 02:11:43,482 INFO (MainThread) [root] Unregistering all secrets (secret:91)
2016-09-23 02:11:43,488 INFO (MainThread) [vds] Setting channels' timeout to 30
seconds. (vmchannels:223)
2016-09-23 02:11:43,492 INFO (MainThread) [vds.MultiProtocolAcceptor] Listening at
:::54321 (protocoldetector:178)
2016-09-23 02:11:44,543 INFO (clientIFinit) [vds] recovery [1:1/1]: recovered domain
45b59cae-f2a0-4d83-8da8-b7c0a21fbe14 from libvirt (recovery:178)
2016-09-23 02:11:44,543 INFO (clientIFinit) [vds] recovery: waiting for 1 domains to go
up (clientIF:545)
2016-09-23 02:11:44,543 INFO (Thread-11) [virt.vm]
vmId=`45b59cae-f2a0-4d83-8da8-b7c0a21fbe14`::VM wrapper has started (vm:1751)
2016-09-23 02:11:44,544 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize(sdUUID=u'5f35b5c0-17d7-4475-9125-e97f1cdb06f9',
spUUID=u'f9374c0e-ae24-4bc1-a596-f61d5f05bc5f',
imgUUID=u'3bdc1ff7-22f9-4263-8955-7e3bfa540edc',
volUUID=u'7e159928-0e2f-423a-a02d-3faddbf55585', options=None) (logUtils:49)
2016-09-23 02:11:44,544 ERROR (Thread-11) [storage.StorageDomainCache] looking for
unfetched domain 5f35b5c0-17d7-4475-9125-e97f1cdb06f9 (sdc:151)
2016-09-23 02:11:44,544 ERROR (Thread-11) [storage.StorageDomainCache] looking for
domain 5f35b5c0-17d7-4475-9125-e97f1cdb06f9 (sdc:168)
2016-09-23 02:11:44,673 INFO (Thread-11) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['metadata'] (lvm:1226)
2016-09-23 02:11:44,947 INFO (Thread-11) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['ids'] (lvm:1226)
2016-09-23 02:11:45,074 INFO (Thread-11) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['leases'] (lvm:1226)
2016-09-23 02:11:45,210 INFO (Thread-11) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['metadata', 'leases',
'ids', 'inbox', 'outbox', 'master'] (lvm:1226)
2016-09-23 02:11:45,219 INFO (hsm/init) [storage.LVM] Refreshing lvs:
vg=bb85ee2f-d674-489f-9377-3eb1f176e8fb lvs=['inbox', 'outbox',
'metadata', 'ids', 'leases', 'master'] (lvm:677)
2016-09-23 02:11:45,386 INFO (Thread-11) [dispatcher] Run and protect: getVolumeSize,
Return response: {'truesize': '1073741824', 'apparentsize':
'1073741824'} (logUtils:52)
2016-09-23 02:11:45,387 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize(sdUUID=u'5f35b5c0-17d7-4475-9125-e97f1cdb06f9',
spUUID=u'f9374c0e-ae24-4bc1-a596-f61d5f05bc5f',
imgUUID=u'65e74f9f-a41b-4636-8e72-db3dd7d73055',
volUUID=u'3a9f341b-4149-4794-88d6-4fd12ff84307', options=None) (logUtils:49)
2016-09-23 02:11:45,387 INFO (Thread-11) [dispatcher] Run and protect: getVolumeSize,
Return response: {'truesize': '7650410496', 'apparentsize':
'7650410496'} (logUtils:52)
2016-09-23 02:11:45,387 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize(sdUUID=u'5f35b5c0-17d7-4475-9125-e97f1cdb06f9',
spUUID=u'f9374c0e-ae24-4bc1-a596-f61d5f05bc5f',
imgUUID=u'69107a7c-acd6-44b0-a481-e7ec13486847',
volUUID=u'88816475-3ea1-4d1f-ac93-7767cf9a2d2c', options=None) (logUtils:49)
2016-09-23 02:11:45,388 INFO (Thread-11) [dispatcher] Run and protect: getVolumeSize,
Return response: {'truesize': '1073741824', 'apparentsize':
'1073741824'} (logUtils:52)
2016-09-23 02:11:45,410 INFO (Thread-11) [virt.vm]
vmId=`45b59cae-f2a0-4d83-8da8-b7c0a21fbe14`::Starting connection (guestagent:234)
2016-09-23 02:11:45,418 INFO (Thread-11) [virt.vm]
vmId=`45b59cae-f2a0-4d83-8da8-b7c0a21fbe14`::CPU running: domain initialization (vm:4653)
2016-09-23 02:11:45,465 WARNING (Thread-11) [vds] Not ready yet, ignoring event
u'|virt|VM_status|45b59cae-f2a0-4d83-8da8-b7c0a21fbe14'
args={u'45b59cae-f2a0-4d83-8da8-b7c0a21fbe14': {'status': 'Up',
'displayInfo': [{'tlsPort': u'5900', 'ipAddress':
'10.35.0.110', 'type': u'spice', 'port': '-1'}],
'hash': '-6596881514735067770', 'displayIp':
'10.35.0.110', 'displayPort': '-1', 'displaySecurePort':
u'5900', 'timeOffset': u'0', 'pauseCode': 'NOERR',
'vcpuQuota': '-1', 'cpuUser': '0.00',
'monitorResponse': '0', 'elapsedTime': '199082',
'displayType': 'qxl', 'cpuSys': '0.00',
'clientIp': '', 'vcpuPeriod': 100000L}} (clientIF:157)
2016-09-23 02:11:45,475 INFO (BindingXMLRPC) [vds] XMLRPC server running
(bindingxmlrpc:63)
2016-09-23 02:11:45,476 INFO (MainThread) [health] Starting health monitor
(interval=60) (health:64)
2016-09-23 02:11:45,525 INFO (hsm/init) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['ids', 'master',
'inbox', 'metadata', 'outbox', 'leases'] (lvm:677)
2016-09-23 02:11:45,544 INFO (clientIFinit) [dispatcher] Run and protect:
getConnectedStoragePoolsList(options=None) (logUtils:49)
2016-09-23 02:11:45,544 INFO (clientIFinit) [dispatcher] Run and protect:
getConnectedStoragePoolsList, Return response: {'poollist': []} (logUtils:52)
2016-09-23 02:11:45,544 INFO (clientIFinit) [vds] recovery: waiting for storage pool to
go up (clientIF:551)
2016-09-23 02:11:45,572 INFO (Reactor thread) [ProtocolDetector.AcceptorImpl] Accepting
connection from ::ffff:10.35.0.102:50379 (protocoldetector:71)
2016-09-23 02:11:45,635 INFO (Reactor thread) [ProtocolDetector.Detector] Detected
protocol stomp from ::ffff:10.35.0.102:50379 (protocoldetector:120)
2016-09-23 02:11:45,636 INFO (Reactor thread) [Broker.StompAdapter] Subscribe command
received (stompreactor:128)
Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/64113
Continuous-Integration: Jenkins CI
Reviewed-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Reviewed-by: Edward Haas <edwardh(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M static/etc/vdsm/logger.conf.in
M tests/run_tests_local.sh.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Michal Skrivanek: Looks good to me, but someone else must approve
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7:23 a.m.
New subject: Change in vdsm[master]: logging: More standard logging format
gerrit-hooks has posted comments on this change.
Change subject: logging: More standard logging format
......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2777
days inactive
2799
days old
vdsm-patches@lists.fedorahosted.org
25 comments
9 participants
participants (9)
-
automation＠ovirt.org -
Dan Kenigsberg -
edwardh＠redhat.com -
fromani＠redhat.com -
michal.skrivanek＠redhat.com -
mzamazal＠redhat.com -
Nir Soffer -
peter.portante＠redhat.com -
Piotr Kliczewski