8:01 a.m.
Nir Soffer has uploaded a new change for review.
Change subject: dockerfile: Minimize docker image
......................................................................
dockerfile: Minimize docker image
Cleaning dnf caches remove 145MiB of useless data slowing down pushing
and pulling the image:
# du -sh /var/cache/*
145M /var/cache/dnf
20K /var/cache/ldconfig
0 /var/cache/libvirt
# dnf clean all
72 files removed
# du -sh /var/cache/*
12K /var/cache/dnf
20K /var/cache/ldconfig
0 /var/cache/libvirt
Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M contrib/Dockerfile.fedora
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/65271/1
diff --git a/contrib/Dockerfile.fedora b/contrib/Dockerfile.fedora
index 5eaa12d..6495167 100644
--- a/contrib/Dockerfile.fedora
+++ b/contrib/Dockerfile.fedora
@@ -41,4 +41,5 @@
which \
&& \
easy_install pip && \
- pip install nose==1.3.7 tox==2.1.1
+ pip install nose==1.3.7 tox==2.1.1 && \
+ dnf clean all
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
8:01 a.m.
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Minimize docker image
......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
8:14 a.m.
Nir Soffer has posted comments on this change.
Change subject: dockerfile: Minimize docker image
......................................................................
Patch Set 1: Verified+1
Verified using travis:
https://travis-ci.org/nirs/vdsm/builds/166142758
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
12:49 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Minimize docker image
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65271/1/contrib/Dockerfile.fedora
File contrib/Dockerfile.fedora:
Line 41: which \
Line 42: && \
Line 43: easy_install pip && \
Line 44: pip install nose==1.3.7 tox==2.1.1 && \
Line 45: dnf clean all
the danger of having two dockerfiles: I guess that the same thing applies to the centos
image.
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
1:11 p.m.
Nir Soffer has posted comments on this change.
Change subject: dockerfile: Minimize docker image
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65271/1/contrib/Dockerfile.fedora
File contrib/Dockerfile.fedora:
Line 41: which \
Line 42: && \
Line 43: easy_install pip && \
Line 44: pip install nose==1.3.7 tox==2.1.1 && \
Line 45: dnf clean all
the danger of having two dockerfiles: I guess that the same thing
applies t
The centos image is much smaller without this change, but I will apply the
same change there.
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
1:25 p.m.
New subject: Change in vdsm[master]: dockerfile: Minimize docker images
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Minimize docker images
......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2 p.m.
New subject: Change in vdsm[master]: dockerfile: Minimize docker images
Nir Soffer has posted comments on this change.
Change subject: dockerfile: Minimize docker images
......................................................................
Patch Set 2: Verified+1
Verified using docker cloud, both images built succesfully and are much smaller now.
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
12:59 a.m.
New subject: Change in vdsm[master]: dockerfile: Minimize docker images
Freddy Rolland has posted comments on this change.
Change subject: dockerfile: Minimize docker images
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:22 a.m.
New subject: Change in vdsm[master]: dockerfile: Minimize docker images
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Minimize docker images
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:22 a.m.
New subject: Change in vdsm[master]: dockerfile: Minimize docker images
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dockerfile: Minimize docker images
......................................................................
dockerfile: Minimize docker images
Cleaning dnf caches remove 145MiB of useless data slowing down pushing
and pulling:
# du -sh /var/cache/*
145M /var/cache/dnf
20K /var/cache/ldconfig
0 /var/cache/libvirt
# dnf clean all
72 files removed
# du -sh /var/cache/*
12K /var/cache/dnf
20K /var/cache/ldconfig
0 /var/cache/libvirt
Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/65271
Continuous-Integration: Jenkins CI
Reviewed-by: Freddy Rolland <frolland(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M contrib/Dockerfile.centos
M contrib/Dockerfile.fedora
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7:22 a.m.
New subject: Change in vdsm[master]: dockerfile: Minimize docker images
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Minimize docker images
......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2800
days inactive
2801
days old
vdsm-patches@lists.fedorahosted.org
10 comments
4 participants
participants (4)
-
automation＠ovirt.org -
Dan Kenigsberg -
frolland＠redhat.com -
Nir Soffer