Change in vdsm[master]: Ignore differences in case when comparing mac addresses

Mark Wu has uploaded a new change for review.

Change subject: Ignore differences in case when comparing mac addresses
......................................................................

Ignore differences in case when comparing mac addresses

Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/1059/1
--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Ignore differences in case when comparing mac addresses
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

Hi! have you bumped into this problem in the field?

--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg

Mark Wu has posted comments on this change.

Change subject: Ignore differences in case when comparing mac addresses
......................................................................

Patch Set 1:

Yes. I created a VM whose mac address has upper case character, and then I got the following exception:

Thread-42::ERROR::2012-01-14 08:53:59,503::utils::393::vm.Vm::(collect) vmId=`c9d25ee1-d4a9-424e-970a-c55daf52961e`::Stats function failed: <AdvancedStatsFunction _sampleNet at 0x2c36420>
Traceback (most recent call last):
  File "/usr/share/vdsm/utils.py", line 389, in collect
    statsFunction()
  File "/usr/share/vdsm/utils.py", line 266, in __call__
    retValue = self._function(*args, **kwargs)
  File "/usr/share/vdsm/libvirtvm.py", line 171, in _sampleNet
    netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
AttributeError: 'NetworkInterfaceDevice' object has no attribute 'name'

This should be caused by that the function _getUnderlyingNetworkInterfaceInfo didn't update the 'name' successfully because of the mismatched mac address. It seems libvirt always store the mac address in lower case in XML file. But I am not sure about it, so I just compare the lower case of the two addresses.

--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Ignore differences in case when comparing mac addresses
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Ignore differences in case when comparing mac addresses
......................................................................

Patch Set 1: Verified

Thanks, Mark!

--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Ignore differences in case when comparing mac addresses
......................................................................

Ignore differences in case when comparing mac addresses

Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Ignore differences in case when comparing mac addresses
......................................................................

Patch Set 2: Verified; Looks good to me, approved

rebased

--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu