Change in vdsm[ovirt-3.5]: Remove redundant prints during rpm installation

Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/32170

to review the following change.

Change subject: Remove redundant prints during rpm installation
......................................................................

Remove redundant prints during rpm installation

Those stdout prints are invalid and doesn't assist to the user.
If configure fails vdsmd won't start and the user will need to
investigate it. But stdout prints in the installation phase won't
assist.

Change-Id: I5284009f1f04382b0cae73a16d1650d54d7649ea
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/30667
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/32170/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index ecac369..8650294 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -704,7 +704,7 @@
 /usr/sbin/usermod -a -G %{cdrom_group} %{qemu_user}
 
 %post
-%{_bindir}/vdsm-tool configure --module sanlock --force
+%{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null
 %{_bindir}/vdsm-tool sebool-config || :
 # set the vdsm "secret" password for libvirt
 %{_bindir}/vdsm-tool set-saslpasswd


-- 
To view, visit http://gerrit.ovirt.org/32170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5284009f1f04382b0cae73a16d1650d54d7649ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant prints during rpm installation
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/130/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/32170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5284009f1f04382b0cae73a16d1650d54d7649ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Remove redundant prints during rpm installation
......................................................................


Remove redundant prints during rpm installation

Those stdout prints are invalid and doesn't assist to the user.
If configure fails vdsmd won't start and the user will need to
investigate it. But stdout prints in the installation phase won't
assist.

Change-Id: I5284009f1f04382b0cae73a16d1650d54d7649ea
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/30667
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/32170
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5284009f1f04382b0cae73a16d1650d54d7649ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant prints during rpm installation
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/32170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5284009f1f04382b0cae73a16d1650d54d7649ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove redundant prints during rpm installation
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/32170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5284009f1f04382b0cae73a16d1650d54d7649ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-HasComments: No