3:50 a.m.
Genadi Chereshnya has uploaded a new change for review.
Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................
netinfo: Return Mac of bond slaves in lower case
getVdsCaps returns MAC of all interfaces in lower case and for bond slaves
it returned it in upper cases - fixing inconsistency
Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Bug-Url: https://bugzilla.redhat.com/1116810
Signed-off-by: Genadi Chereshnya <gcheresh(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31888
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
(cherry picked from commit bd4a297c25fc5d6e241d28ca5eb0fb2b4c538e6e)
---
M lib/vdsm/netinfo.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/32289/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 7bd8075..5dc2cd6 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -518,8 +518,7 @@
if line.startswith('Slave Interface: '):
slave = line[len('Slave Interface: '):-1]
if line.startswith('Permanent HW addr: '):
- addr = line[len('Permanent HW addr: '):-1]
- paddr[slave] = addr.upper()
+ paddr[slave] = line[len('Permanent HW addr: '):-1]
return paddr
--
To view, visit http://gerrit.ovirt.org/32289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com>
10:06 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/131/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:48 a.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................
netinfo: Return Mac of bond slaves in lower case
getVdsCaps returns MAC of all interfaces in lower case and for bond slaves
it returned it in upper cases - fixing inconsistency
Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Bug-Url: https://bugzilla.redhat.com/1116810
Signed-off-by: Genadi Chereshnya <gcheresh(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31888
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
(cherry picked from commit bd4a297c25fc5d6e241d28ca5eb0fb2b4c538e6e)
Reviewed-on: http://gerrit.ovirt.org/32289
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/netinfo.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Genadi Chereshnya: Verified
Yaniv Bronhaim: Looks good to me, approved
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
7:48 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:09 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
12:35 a.m.
Genadi Chereshnya has posted comments on this change.
Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:54 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_tests_gerrit/10/ : There was an
infra issue, please contact infra(a)ovirt.org
--
To view, visit http://gerrit.ovirt.org/32289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3544
days inactive
3545
days old
vdsm-patches@lists.fedorahosted.org
6 comments
4 participants
participants (4)
-
Dan Kenigsberg -
gcheresh＠redhat.com -
Jenkins CI RO -
ybronhei＠redhat.com