Francesco Romani has posted comments on this change.
Change subject: graphics: use global displayNetwork if no local specified
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
-1 for visibility and request
looks almost OK, minor comments inside.
Could you please:
- add one (or more!) unit test into deviceTests.py?
- mention the inspiration patch in the commit message?
https://gerrit.ovirt.org/#/c/46224/3/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:
Line 62: # update the device to use global parameters.
Line 63: network = None
Line 64:
Line 65: if 'displayNetwork' in self.specParams:
Line 66: network = self.specParams.get('displayNetwork')
no need of get() here, we can use
network = self.specParams['displayNetwork']
Line 67: elif 'displayNetwork' in conf:
Line 68: network = conf.get('displayNetwork')
Line 69:
Line 70: if network:
Line 64:
Line 65: if 'displayNetwork' in self.specParams:
Line 66: network = self.specParams.get('displayNetwork')
Line 67: elif 'displayNetwork' in conf:
Line 68: network = conf.get('displayNetwork')
same
Line 69:
Line 70: if network:
Line 71: self.specParams['displayIp'] = _getNetworkIp(network)
Line 72: self.specParams['displayNetwork'] = network
--
To view, visit
https://gerrit.ovirt.org/46224
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I537e294fe64d3d2a559f3c77c43c9c845e0b9fda
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes