Change in vdsm[master]: Revert "net/api: drop support for legacy mgmt networks"

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: Revert "net/api: drop support for legacy mgmt networks"
......................................................................

Revert "net/api: drop support for legacy mgmt networks"

This reverts commit d1e8f872b913e4b0dc222c0d2cc2906e9807f3cb.
We need the reverted code because current Engines does not pass
defaultRoute=True on clusterLevels <= 3.3.

Bug-Url: https://bugzilla.redhat.com/1259000
Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M lib/vdsm/constants.py.in
M vdsm/network/api.py
2 files changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/45712/1

diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 82fc6d1..c9dff39 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -25,6 +25,9 @@
 
 RHEV_ENABLED = False if '@RHEV_TRUE@' else True
 
+# VDSM management networks
+LEGACY_MANAGEMENT_NETWORKS = ('ovirtmgmt', 'rhevm')
+
 # SMBIOS manufacturer
 SMBIOS_MANUFACTURER = '@SMBIOS_MANUFACTURER@'
 SMBIOS_OSNAME = '@SMBIOS_OSNAME@'
diff --git a/vdsm/network/api.py b/vdsm/network/api.py
index 5b3a905..12639ab 100755
--- a/vdsm/network/api.py
+++ b/vdsm/network/api.py
@@ -87,7 +87,7 @@
                         bondingOptions=None, nics=None, mtu=None, ipaddr=None,
                         netmask=None, gateway=None, bootproto=None,
                         ipv6addr=None, ipv6gateway=None, ipv6autoconf=None,
-                        dhcpv6=None, defaultRoute=False, _netinfo=None,
+                        dhcpv6=None, defaultRoute=None, _netinfo=None,
                         configurator=None, blockingdhcp=None,
                         implicitBonding=None, opts=None):
     """
@@ -249,7 +249,7 @@
                 ipv6addr=None, ipv6gateway=None, ipv6autoconf=None,
                 force=False, configurator=None, bondingOptions=None,
                 bridged=True, _netinfo=None, hostQos=None,
-                defaultRoute=False, blockingdhcp=False, **options):
+                defaultRoute=None, blockingdhcp=False, **options):
     nics = nics or ()
     if _netinfo is None:
         _netinfo = netinfo.NetInfo()
@@ -288,6 +288,13 @@
             for nic in nics:
                 _validateInterNetworkCompatibility(_netinfo, vlan, nic)
 
+    # defaultRoute is set either explicitly by the client, OR if we're adding
+    # the management network.
+    # REQUIRED_FOR: clusterLevel<=3.3
+    #       remove reference to constants.LEGACY_MANAGEMENT_NETWORKS
+    if defaultRoute is None:
+        defaultRoute = network in constants.LEGACY_MANAGEMENT_NETWORKS
+
     logging.info("Adding network %s with vlan=%s, bonding=%s, nics=%s,"
                  " bondingOptions=%s, mtu=%s, bridged=%s, defaultRoute=%s,"
                  "options=%s", network, vlan, bonding, nics, bondingOptions,


-- 
To view, visit https://gerrit.ovirt.org/45712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: Revert "net/api: drop support for legacy mgmt networks"
......................................................................


Patch Set 1:

* Update tracker::#1259000::OK
* Check Bug-Url::OK
* Check Public Bug::#1259000::OK, public bug
* Check Product::#1259000::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/45712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Ido Barkan has posted comments on this change.

Change subject: Revert "net/api: drop support for legacy mgmt networks"
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/45712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Ido Barkan has posted comments on this change.

Change subject: Revert "net/api: drop support for legacy mgmt networks"
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/45712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Revert "net/api: drop support for legacy mgmt networks"
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/45712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Revert "net/api: drop support for legacy mgmt networks"
......................................................................


Revert "net/api: drop support for legacy mgmt networks"

This reverts commit d1e8f872b913e4b0dc222c0d2cc2906e9807f3cb.
We need the reverted code because current Engines does not pass
defaultRoute=True on clusterLevels <= 3.3.

Bug-Url: https://bugzilla.redhat.com/1259000
Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/45712
Continuous-Integration: Jenkins CI
Tested-by: Ido Barkan <ibarkan(a)redhat.com&gt;
Reviewed-by: Ido Barkan <ibarkan(a)redhat.com&gt;
---
M lib/vdsm/constants.py.in
M vdsm/network/api.py
2 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: Revert "net/api: drop support for legacy mgmt networks"
......................................................................


Patch Set 2:

* Update tracker::#1259000::OK
* Set MODIFIED::bug 1259000::::#1259000::::IGNORE, not oVirt prod but Red Hat Enterprise
Virtualization Manager

-- 
To view, visit https://gerrit.ovirt.org/45712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb308ffae614e8f349652ac2916a2ed284677b9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No