Change in vdsm[master]: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64

Change in vdsm[master]: hostdev:...

Change in vdsm[master]: Revert...

vdelima＠redhat.com

Monday, 6 October 2014 Mon, 6 Oct '14

4 p.m.

Vitor de Lima has uploaded a new change for review. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 Recent libvirt versions already include a virtual USB keyboard and mouse in guests with graphical consoles. This patch does not include any information about input devices in the domain XML in order to libvirt handle the creation of these devices automatically. Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122627 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M vdsm/virt/vm.py M vdsm/virt/vmxml.py 2 files changed, 3 insertions(+), 27 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/33871/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 1eebb69..5b39752 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2679,7 +2679,9 @@ _VMCHANNEL_DEVICE_NAME) domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), _QEMU_GA_DEVICE_NAME) - domxml.appendInput() + + if self.arch == caps.Architecture.X86_64: + domxml.appendInput() if self.arch == caps.Architecture.PPC64: domxml.appendEmulator() @@ -2694,9 +2696,6 @@ for drive in self._devices[DISK_DEVICES][:]: for leaseElement in drive.getLeasesXML(): domxml._devices.appendChild(leaseElement) - - if self.arch == caps.Architecture.PPC64: - domxml.appendKeyboardDevice() return domxml.toxml() diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py index eb07ba9..a83adb1 100644 --- a/vdsm/virt/vmxml.py +++ b/vdsm/virt/vmxml.py @@ -165,14 +165,6 @@ domainAttrs = {'type': domainType} - # Hack around libvirt issue BZ#988070, this is going to be removed as - # soon as the domain XML format supports the specification of USB - # keyboards - - if self.arch == caps.Architecture.PPC64: - domainAttrs['xmlns:qemu'] = \ - 'http://libvirt.org/schemas/domain/qemu/1.0' - self.dom = Element('domain', **domainAttrs) self.doc.appendChild(self.dom) @@ -444,21 +436,6 @@ inputAttrs = {'type': 'mouse', 'bus': mouseBus} self._devices.appendChildWithArgs('input', **inputAttrs) - - def appendKeyboardDevice(self): - """ - Add keyboard device for ppc64 using a QEMU argument directly. - This is a workaround to the issue BZ#988070 in libvirt - - <qemu:commandline> - <qemu:arg value='-usbdevice'/> - <qemu:arg value='keyboard'/> - </qemu:commandline> - """ - commandLine = Element('qemu:commandline') - commandLine.appendChildWithArgs('qemu:arg', value='-usbdevice') - commandLine.appendChildWithArgs('qemu:arg', value='keyboard') - self.dom.appendChild(commandLine) def appendEmulator(self): emulatorPath = '/usr/bin/qemu-system-' + self.arch -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>

Show replies by date

Jenkins CI RO

Monday, 6 October Mon, 6 Oct

4:01 p.m.

fromani＠redhat.com

Wednesday, 8 October Wed, 8 Oct

6:49 a.m.

Francesco Romani has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 1: (2 comments) Not sure you actually want a review already - the more or less accepted convention is to not review changes which are marked as draft. However, since I'm here... :) http://gerrit.ovirt.org/#/c/33871/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-10-06 17:00:35 -0300 Line 6: Line 7: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 Line 8: Line 9: Recent libvirt versions already include a virtual USB keyboard and nice! but 'recent libvirt versions' is a bit too vague. Can you please specify the version here in the commit message and, if needed, bump the requirements in the spec file/debian control file? Line 10: mouse in guests with graphical consoles. This patch does not include Line 11: any information about input devices in the domain XML in order to Line 12: libvirt handle the creation of these devices automatically. Line 13: http://gerrit.ovirt.org/#/c/33871/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2679: _VMCHANNEL_DEVICE_NAME) Line 2680: domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), Line 2681: _QEMU_GA_DEVICE_NAME) Line 2682: Line 2683: if self.arch == caps.Architecture.X86_64: I don't get why we still need to do that on x86_64; or, to put in different words, why this is not needed on PPC64. Can you please elaborate? Line 2684: domxml.appendInput() Line 2685: Line 2686: if self.arch == caps.Architecture.PPC64: Line 2687: domxml.appendEmulator() -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

vdelima＠redhat.com

7:29 a.m.

Vitor de Lima has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33871/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-10-06 17:00:35 -0300 Line 6: Line 7: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 Line 8: Line 9: Recent libvirt versions already include a virtual USB keyboard and

...

nice! but 'recent libvirt versions' is a bit too vague.

This feature was introduced in libvirt 1.2.2 (commits 78730478aa3e3157b9d86b1054d32f61d6616880 and cffa51b81d3ad166a7caf3d4ec08d88c41f273fe). And it is present in PowerKVM (which includes libvirt version 1.1.3). Line 10: mouse in guests with graphical consoles. This patch does not include Line 11: any information about input devices in the domain XML in order to Line 12: libvirt handle the creation of these devices automatically. Line 13: http://gerrit.ovirt.org/#/c/33871/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2679: _VMCHANNEL_DEVICE_NAME) Line 2680: domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), Line 2681: _QEMU_GA_DEVICE_NAME) Line 2682: Line 2683: if self.arch == caps.Architecture.X86_64:

...

I don't get why we still need to do that on x86_64; or, to put in different

libvirt automatically creates a USB mouse and keyboard if there are any graphics devices present in the domain XML, if the appendInput is used in ppc64 you would end up with 2 USB mice. Line 2684: domxml.appendInput() Line 2685: Line 2686: if self.arch == caps.Architecture.PPC64: Line 2687: domxml.appendEmulator() -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

vdelima＠redhat.com

8:31 a.m.

Vitor de Lima has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 2: Verified+1 Verified by successfully running a ppc64 VM with only one keyboard and one mouse. -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

8:39 a.m.

oVirt Jenkins CI Server has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11892/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1751/ : There was an infra issue, please contact infra(a)ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12683/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Dan Kenigsberg

5:43 p.m.

Dan Kenigsberg has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33871/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-10-08 10:29:36 -0300 Line 6: Line 7: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 Line 8: Line 9: Since libvirt 1.2.2 a virtual USB keyboard and mouse is included Please update the spec file, with the proper libvirt versions for Fedora and el6. Line 10: in ppc64 guests with graphical consoles. This patch does not insert Line 11: any information about input devices in the domain XML in order to Line 12: libvirt handle the creation of these devices automatically. Line 13: -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

vdelima＠redhat.com

Tuesday, 21 October Tue, 21 Oct

12:58 p.m.

Vitor de Lima has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33871/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-10-08 10:29:36 -0300 Line 6: Line 7: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 Line 8: Line 9: Since libvirt 1.2.2 a virtual USB keyboard and mouse is included

...

Please update the spec file, with the proper libvirt versions for Fedora an

VDSM now depends on libvirt 1.2.3 for Fedora and RHEL 7. Line 10: in ppc64 guests with graphical consoles. This patch does not insert Line 11: any information about input devices in the domain XML in order to Line 12: libvirt handle the creation of these devices automatically. Line 13: -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

Jenkins CI RO

1 p.m.

oVirt Jenkins CI Server has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13035/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1781/ : There was an infra issue, please contact infra(a)ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12877/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12087/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

michal.skrivanek＠redhat.com

Tuesday, 25 November Tue, 25 Nov

1:42 a.m.

Michal Skrivanek has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 3: Code-Review+1 looks good to me, Dan? -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

fromani＠redhat.com

2:05 a.m.

Francesco Romani has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 3: libvirt deps were relaxed to 1.1.1 (by myself :) ). codewise patch looks fine, problem is once again dependencies handling, Dan's comment as per revision 2 is valid again. -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

fromani＠redhat.com

5:11 a.m.

Francesco Romani has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 3: Code-Review-1 -1 just because we need to wait for libvirt dep to get fixed -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Dan Kenigsberg

5:13 a.m.

...

VDSM now depends on libvirt 1.2.3 for Fedora and RHEL 7.

http://gerrit.ovirt.org/34340 dropped it to 1.1.1 Can we really remove this hack on el7? Line 10: in ppc64 guests with graphical consoles. This patch does not insert Line 11: any information about input devices in the domain XML in order to Line 12: libvirt handle the creation of these devices automatically. Line 13: -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

Dan Kenigsberg

Tuesday, 2 December Tue, 2 Dec

6:03 a.m.

Dan Kenigsberg has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33871/4/vdsm.spec.in File vdsm.spec.in: Line 160: Requires: libguestfs-tools-c >= 1:1.26.7-2 Line 161: %endif Line 162: Line 163: %ifarch ppc64 Line 164: %define libvirt_version 1.2.2 Does this split really help? Would el7-for-ppc ship a different libvirt version than that in x86? This would surprise me quite a bit. Line 165: %else Line 166: %define libvirt_version 1.1.1 Line 167: %endif Line 168: -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

Jenkins CI RO

6:10 a.m.

oVirt Jenkins CI Server has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/... : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/... : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13032/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13984/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/128/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1988/ : There was an infra issue, please contact infra(a)ovirt.org -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

vdelima＠redhat.com

6:21 a.m.

Vitor de Lima has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33871/4/vdsm.spec.in File vdsm.spec.in: Line 160: Requires: libguestfs-tools-c >= 1:1.26.7-2 Line 161: %endif Line 162: Line 163: %ifarch ppc64 Line 164: %define libvirt_version 1.2.2

...

Does this split really help? Would el7-for-ppc ship a different libvirt ver

This way VDSM still builds on RHEL 7, otherwise we would have unnecessarily raised the required version in x86-64. Like the issue with the kernel version in the lscpu patch, I'm sure checking the package version is not a good idea because frequently those features are backported to earlier versions. Line 165: %else Line 166: %define libvirt_version 1.1.1 Line 167: %endif Line 168: -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

Dan Kenigsberg

Tuesday, 20 January Tue, 20 Jan

5:15 a.m.

...

This way VDSM still builds on RHEL 7, otherwise we would have unnecessarily

how can vdsm build on el7, if the ppc arch requires a non-existing libvirt? Line 165: %else Line 166: %define libvirt_version 1.1.1 Line 167: %endif Line 168: -- To view, visit http://gerrit.ovirt.org/33871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

automation＠ovirt.org

Thursday, 26 March Thu, 26 Mar

6:33 a.m.

automation(a)ovirt.org has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 5: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

6:33 a.m.

Jenkins CI RO

6:33 a.m.

Jenkins CI RO

6:33 a.m.

Jenkins CI RO

6:33 a.m.

Jenkins CI RO

6:33 a.m.

Jenkins CI RO

6:33 a.m.

automation＠ovirt.org

6:34 a.m.

automation(a)ovirt.org has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 6: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

6:35 a.m.

Jenkins CI RO

6:36 a.m.

Jenkins CI RO

6:38 a.m.

Jenkins CI RO

6:48 a.m.

oVirt Jenkins CI Server has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/683/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/... : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17162/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1... : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/... : SUCCESS -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

fromani＠redhat.com

8:28 a.m.

Francesco Romani has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 6: (1 comment) requirements are still unclear to me. https://gerrit.ovirt.org/#/c/33871/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-12-01 17:02:27 -0200 Line 4: Commit: Martin Polednik <mpolednik(a)redhat.com> Line 5: CommitDate: 2015-03-26 12:34:13 +0100 Line 6: Line 7: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 s/vmxml.py, vm.py/virt Line 8: Line 9: Since RHEL 7.2 a virtual USB keyboard and mouse is included Line 10: in ppc64 guests with graphical consoles. This patch does not insert Line 11: any information about input devices in the domain XML in order to -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

Martin Polednik

8:37 a.m.

Martin Polednik has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 6: There are pretty much no requirements: it will be in any version of ppc64(le) we support afaik. -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

fromani＠redhat.com

8:46 a.m.

Francesco Romani has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 6: sorry for cyptic comment. I meant the *libvirt/OS* requirements. In the commit message we read 'Since RHEL 7.2', but 7.2 is still far away... -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Martin Polednik

8:59 a.m.

Martin Polednik has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 6: ppc64le targets 7.2 (same for 3.6), I'm not aware of lesser rhel versions to be supported -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

michal.skrivanek＠redhat.com

10:33 a.m.

Michal Skrivanek has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 6: there's no need to mention "since 7.2", it's actually in all the currently supported OSes by ovirt 3.5 already. It's just a historical thing from the early days of PPC support and we should drop it -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

automation＠ovirt.org

Monday, 25 May Mon, 25 May

5:32 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 7: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

mskrivan＠redhat.com

5:33 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Michal Skrivanek has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 7: Code-Review+1 should be ok for 3.6 -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

8:13 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 8: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

Monday, 24 August Mon, 24 Aug

6:34 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 9: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Martin Polednik

7:19 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Martin Polednik has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 9: Verified+1 Added by libvirt automatically, verified by looking around the Open Firmware via keyboard. -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

fromani＠redhat.com

7:22 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Francesco Romani has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

fromani＠redhat.com

7:23 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Francesco Romani has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 9: -Code-Review -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

fromani＠redhat.com

7:25 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Francesco Romani has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 9: Code-Review+1 (1 comment) partial ACK. looks mostly OK, but one question inside https://gerrit.ovirt.org/#/c/33871/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1656: _VMCHANNEL_DEVICE_NAME) Line 1657: domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), Line 1658: _QEMU_GA_DEVICE_NAME) Line 1659: Line 1660: if self.arch == caps.Architecture.X86_64: Could you please elaborate on this? i found surprising we need this only on x86_64 Line 1661: domxml.appendInput() Line 1662: Line 1663: if self.arch == caps.Architecture.PPC64: Line 1664: domxml.appendEmulator() -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: Yes

automation＠ovirt.org

8:38 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 10: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Martin Polednik

8:39 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Martin Polednik has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/33871/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1656: _VMCHANNEL_DEVICE_NAME) Line 1657: domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), Line 1658: _QEMU_GA_DEVICE_NAME) Line 1659: Line 1660: if self.arch == caps.Architecture.X86_64:

...

Could you please elaborate on this? i found surprising we need this only on

The PPC archs add this automatically (see https://bugzilla.redhat.com/show_bug.cgi?id=988070). It may not even be needed for x86_64, but let's keep it separate. Line 1661: domxml.appendInput() Line 1662: Line 1663: if self.arch == caps.Architecture.PPC64: Line 1664: domxml.appendEmulator() -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: Yes

Martin Polednik

8:39 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Martin Polednik has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 10: Verified+1 Removed PPC64 specific code in appendInput also. -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

fromani＠redhat.com

Tuesday, 25 August Tue, 25 Aug

4:17 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Francesco Romani has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 10: Code-Review+2 raising score and trusting you guys on PPC64 dark corners. -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

4:17 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 11: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

fromani＠redhat.com

4:41 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Francesco Romani has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 11: Code-Review+1 make check fails locally. Investigating. -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Martin Polednik

6:48 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Martin Polednik has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 11: -Verified Evilness spotted, needs a bit of tweaking. -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

6:58 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 12: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

Monday, 31 August Mon, 31 Aug

8:02 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 13: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

8:51 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 14: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

fromani＠redhat.com

Tuesday, 1 September Tue, 1 Sep

2:16 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Francesco Romani has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 14: Code-Review+2 (1 comment) ok, now looks fine to me https://gerrit.ovirt.org/#/c/33871/14/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1599: domxml._appendAgentDevice(self._guestSocketFile.decode('utf-8'), Line 1600: _VMCHANNEL_DEVICE_NAME) Line 1601: domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), Line 1602: _QEMU_GA_DEVICE_NAME) Line 1603: spurious, but not worth enough to resubmit (again) Line 1604: domxml.appendInput() Line 1605: Line 1606: if self.arch == caps.Architecture.PPC64: Line 1607: domxml.appendEmulator() -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: Yes

Martin Polednik

Wednesday, 2 September Wed, 2 Sep

4:24 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Martin Polednik has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

Tuesday, 15 September Tue, 15 Sep

10:21 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 15: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Martin Polednik

10:31 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Martin Polednik has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

fromani＠redhat.com

10:34 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Francesco Romani has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Dan Kenigsberg

Wednesday, 16 September Wed, 16 Sep

9:25 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Dan Kenigsberg has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 15: I see that https://bugzilla.redhat.com/show_bug.cgi?id=988070 is solved in libvirt-1.2.2 which we already require. Taking. -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Dan Kenigsberg

9:25 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... virt: Remove QEMU passthrough hack in ppc64 Ever since 3.5 a virtual USB keyboard and mouse is included in ppc64 guests with graphical consoles. This patch does not insert any information about input devices in the domain XML in order to libvirt handle the creation of these devices automatically. Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122627 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/33871 Tested-by: Martin Polednik <mpolednik(a)redhat.com> Reviewed-by: Francesco Romani <fromani(a)redhat.com> Continuous-Integration: Jenkins CI --- M tests/vmTestsData.py M vdsm/virt/vm.py M vdsm/virt/vmxml.py 3 files changed, 4 insertions(+), 37 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

automation＠ovirt.org

9:25 a.m.

New subject: Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64

automation(a)ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ...................................................................... Patch Set 16: * Update tracker::#1122627::OK * Check TR::#1122627::ERROR, 3.6.0 should not match .* -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

3153

days inactive

3498

days old

vdsm-patches@lists.fedorahosted.org

Manage subscription

59 comments

8 participants

tags (0)

participants (8)

automation＠ovirt.org
Dan Kenigsberg
fromani＠redhat.com
Jenkins CI RO
Martin Polednik
michal.skrivanek＠redhat.com
mskrivan＠redhat.com
vdelima＠redhat.com

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Change in vdsm[master]: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64